Bug 216609 – Fixed some corner cases of scrolling

• Status: NEW
• Component: Scrolling

[cathiechen]

Fixed some corner cases of scrolling.

[cathiechen]

Created attachment 408922 [details]
Patch

[cathiechen]

Hi Simon and Fred,

This patch fixes some corner case I met while implementing scrollend event.
I think it'd good to have a separating bug to fix these for the scrollend patch is getting big now.

Please take a look, thanks:)

[Simon Fraser (smfr)]

Comment on attachment 408922 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408922&action=review

> Source/WebCore/ChangeLog:3
> +        Fixed some corner cases of scrolling

This is a bit vague. Maybe it indicates that this patch should really be separated.

Are any of these fixes testable?

[cathiechen]

Comment on attachment 408922 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408922&action=review

Hi Simon,

Thanks for the review:)

>> Source/WebCore/ChangeLog:3
>> +        Fixed some corner cases of scrolling
> 
> This is a bit vague. Maybe it indicates that this patch should really be separated.
> 
> Are any of these fixes testable?

Yeah, I think it's a good idea to split them. These fixes are not very related. I couldn't find a good tile for them.

Regarding the test, maybe we can create one for user scroll interrupt the programmatic scroll animation. Others seem not easy to test, for they only effect the internal state.

[Radar WebKit Bug Importer]

<rdar://problem/69434613>

[Ahmad Saleem]

It seems this r+ patch didn’t landed, do we need to fix these issues now?

[Simon Fraser (smfr)]

I think we do want these, but the patch needs splitting up, and some tests written.

[cathiechen]

Ah, ok, let me take a look at it today:)

[Ahmad Saleem]

Partially done in https://commits.webkit.org/229661@main