WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
216770
[GLIB] imported/w3c/web-platform-tests/css/css-flexbox/flexbox_stf-table-singleline.html is an image only failure since
r267183
https://bugs.webkit.org/show_bug.cgi?id=216770
Summary
[GLIB] imported/w3c/web-platform-tests/css/css-flexbox/flexbox_stf-table-sing...
Diego Pino
Reported
2020-09-21 03:37:14 PDT
These two tests started failing in
r267183
: imported/w3c/web-platform-tests/css/css-flexbox/flexbox_stf-table-singleline.html imported/w3c/web-platform-tests/css/css-flexbox/flexbox_stf-table-singleline-2.html The tests were marked as ImageOnlyFailure, but were removed from test expectations in
r267183
. The post-commit bots report these tests as ImageOnlyFailure since then. See:
https://build.webkit.org/results/WPE%20Linux%2064-bit%20Release%20(Tests)/r267334%20(20105)/imported/w3c/web-platform-tests/css/css-flexbox/flexbox_stf-table-singleline-2-diffs.html
Attachments
Add attachment
proposed patch, testcase, etc.
Sergio Villar Senin
Comment 1
2020-09-22 06:37:13 PDT
Do all ports report that issue? I say this because I locally have a 1px diff in those tests but it's caused by font rendering.
Radar WebKit Bug Importer
Comment 2
2020-09-28 03:38:19 PDT
<
rdar://problem/69689806
>
Diego Pino
Comment 3
2020-10-05 11:15:01 PDT
Since the tests were removed from test expectations in
r267183
, these two tests are passsing in iOS and Mac, for example, but they're failing in GTK and WPE.
https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-flexbox%2Fflexbox_stf-table-singleline.html&platform=GTK&platform=WPE&platform=ios&platform=mac
Sergio Villar Senin
Comment 4
2020-10-06 01:06:53 PDT
(In reply to Diego Pino from
comment #3
)
> Since the tests were removed from test expectations in
r267183
, these two > tests are passsing in iOS and Mac, for example, but they're failing in GTK > and WPE. > >
https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb
- > platform-tests%2Fcss%2Fcss-flexbox%2Fflexbox_stf-table-singleline. > html&platform=GTK&platform=WPE&platform=ios&platform=mac
Yeah that's what I have observed too. The thing is that the failure is caused by a 1px difference rendering fonts. I'll submit a PR to wpt which sets the Ahem font because the actual text is irrelevant for the test.
Sergio Villar Senin
Comment 5
2020-10-06 01:14:16 PDT
PR uploaded
https://github.com/web-platform-tests/wpt/pull/26005
Diego Pino
Comment 6
2022-01-02 18:04:17 PST
These tests have been passing for WebKitGTK and WPE for the last 4000 revisions:
https://results.webkit.org/?platform=WPE&platform=GTK&limit=4000&suite=layout-tests&suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-flexbox%2Fflexbox_stf-table-singleline.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-flexbox%2Fflexbox_stf-table-singleline-2.html
There are no test failures filed under this bug. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug