Bug 216577 - [css-flex] Remove flexbox's specific computePreferredLogicalWidths()
Summary: [css-flex] Remove flexbox's specific computePreferredLogicalWidths()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sergio Villar Senin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-15 12:55 PDT by Sergio Villar Senin
Modified: 2020-09-21 03:37 PDT (History)
12 users (show)

See Also:

Attachments
Patch (9.11 KB, patch)
2020-09-15 13:05 PDT, Sergio Villar Senin 		darin: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (6.95 KB, patch)
2020-09-16 04:53 PDT, Sergio Villar Senin 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Villar Senin 2020-09-15 12:55:06 PDT 
[css-flex] Remove flexbox's specific computePreferredLogicalWidths()
Comment 1 Sergio Villar Senin 2020-09-15 13:05:58 PDT 
Created attachment 408850 [details]
Patch
Comment 2 Sergio Villar Senin 2020-09-16 04:53:48 PDT 
Created attachment 408912 [details]
Patch
Comment 3 Sergio Villar Senin 2020-09-16 07:37:08 PDT 
I was removing too much code. The one in RenderBlock is ankward but we should leave it untouched until it isn't properly fixed in flexbox.
Comment 4 Sergio Villar Senin 2020-09-17 01:01:15 PDT 
Committed r267183: <https://trac.webkit.org/changeset/267183>
Comment 5 Radar WebKit Bug Importer 2020-09-17 01:02:16 PDT 
<rdar://problem/69049162>