Bug 216703 - Regression(r265280) Web Audio sources malfunction when disconnected from the audio graph
Summary: Regression(r265280) Web Audio sources malfunction when disconnected from the ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: Safari Technology Preview
Hardware: All Other
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks: 212611 215127
  Show dependency treegraph
 
Reported: 2020-09-18 10:05 PDT by Justin Uberti
Modified: 2020-09-24 08:11 PDT (History)
9 users (show)

See Also:


Attachments
Patch (3.77 KB, patch)
2020-09-24 02:22 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Uberti 2020-09-18 10:05:48 PDT
Observed in STP 113 and iOS14 GA. Does not occur in Chrome or Safari 13.

When using a Web Audio graph of the form:

(BufferSource) -> (MediaStreamDestination) -> (HTMLMediaElement)

disconnecting the BufferSource from the graph causes a malfunction, and garbage audio to be fed to the HTMLMediaElement. Setting HTMLMediaElement.srcObject = null works around the issue.

Demo: https://jsfiddle.net/juberti/dev32of4/
Comment 1 Radar WebKit Bug Importer 2020-09-18 10:08:12 PDT
<rdar://problem/69158436>
Comment 2 Chris Dumez 2020-09-23 16:05:03 PDT
I am able to reproduce. Thank you for the reproduction case, I will investigate.
Comment 3 Chris Dumez 2020-09-23 16:26:52 PDT
This is a regression from http://trac.webkit.org/changeset/265280.
Comment 4 youenn fablet 2020-09-24 02:22:37 PDT
Created attachment 409546 [details]
Patch
Comment 5 EWS 2020-09-24 08:11:35 PDT
Committed r267530: <https://trac.webkit.org/changeset/267530>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409546 [details].