WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
216641
Add support for speaker selection
https://bugs.webkit.org/show_bug.cgi?id=216641
Summary
Add support for speaker selection
youenn fablet
Reported
Thursday, September 17, 2020 10:51:10 AM UTC
Add support for speaker selection
Attachments
WIP
(67.94 KB, patch)
2020-09-17 03:10 PDT
,
youenn fablet
no flags
Details
Formatted Diff
Diff
WIP
(68.40 KB, patch)
2020-09-17 04:44 PDT
,
youenn fablet
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
WIP
(74.38 KB, patch)
2020-09-17 05:07 PDT
,
youenn fablet
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
WIP
(75.77 KB, patch)
2020-09-17 05:34 PDT
,
youenn fablet
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
WIP
(75.92 KB, patch)
2020-09-17 06:16 PDT
,
youenn fablet
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
WIP
(75.89 KB, patch)
2020-09-17 06:37 PDT
,
youenn fablet
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
WIP
(75.92 KB, patch)
2020-09-17 06:47 PDT
,
youenn fablet
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
Show Obsolete
(6)
View All
Add attachment
proposed patch, testcase, etc.
youenn fablet
Comment 1
Thursday, September 17, 2020 11:10:55 AM UTC
Created
attachment 409016
[details]
WIP
youenn fablet
Comment 2
Thursday, September 17, 2020 12:44:08 PM UTC
Created
attachment 409022
[details]
WIP
youenn fablet
Comment 3
Thursday, September 17, 2020 1:07:51 PM UTC
Created
attachment 409024
[details]
WIP
youenn fablet
Comment 4
Thursday, September 17, 2020 1:34:36 PM UTC
Created
attachment 409025
[details]
WIP
youenn fablet
Comment 5
Thursday, September 17, 2020 2:16:03 PM UTC
Created
attachment 409027
[details]
WIP
youenn fablet
Comment 6
Thursday, September 17, 2020 2:37:05 PM UTC
Created
attachment 409029
[details]
WIP
youenn fablet
Comment 7
Thursday, September 17, 2020 2:47:42 PM UTC
Created
attachment 409030
[details]
WIP
youenn fablet
Comment 8
Friday, September 18, 2020 1:19:25 PM UTC
***
Bug 179415
has been marked as a duplicate of this bug. ***
Eric Carlson
Comment 9
Friday, September 18, 2020 6:47:59 PM UTC
Comment on
attachment 409030
[details]
WIP View in context:
https://bugs.webkit.org/attachment.cgi?id=409030&action=review
> Source/WebCore/ChangeLog:8 > +
https://bugs.webkit.org/show_bug.cgi?id=216641
> + > + Reviewed by NOBODY (OOPS!). > + > + MediaDevices now receive non hashed device IDs.
I think it would be a good idea to point to the spec here.
> Source/WebCore/ChangeLog:9 > + We hash them before exposing them and keep a mapping in WebProcess between hashed audoi output device Ids and the persistent Ids.
s/audoi/audio/
> Source/WebCore/ChangeLog:21 > + All these methods can be used based on user gesture.
This is unclear, it makes it sound like they are optionally gated on a user gesture.
> Source/WebCore/Modules/mediastream/MediaDevices.cpp:227 > + auto groupId = RealtimeMediaSourceCenter::singleton().hashStringWithSalt(newDevice.groupId(), m_groupIdHashSalt);
All of the capture classes should now set supportedConstraints.setSupportsGroupId(true) so MediaTrackSupportedConstraints.groupId returns `true`
> Source/WebCore/Modules/mediastream/MediaDevices.cpp:356 > + document->topDocument().setDefaultAudioOutputDeviceId(WTFMove(persistentId)); > + m_audioOutputDeviceId = WTFMove(deviceId);
It might be better to swap the order of these lines in case a side effect of calling setDefaultAudioOutputDeviceId checks audioOutputDevice()
Radar WebKit Bug Importer
Comment 10
Thursday, September 24, 2020 10:52:16 AM UTC
<
rdar://problem/69491182
>
Jovan Chohan
Comment 11
Friday, August 27, 2021 7:35:21 PM UTC
Is there any timeline for this feature support?
David P
Comment 12
Monday, July 11, 2022 1:15:10 AM UTC
Support for setSinkId is listed for Safari Tech Preview release 148 at
https://developer.apple.com/safari/technology-preview/release-notes/
and it seems the current release is 136
https://webkit.org/blog/category/safari-technology-preview/page/2/
So should this issue have a status other than New?
Olivier Anguenot
Comment 13
Wednesday, March 1, 2023 8:13:31 PM UTC
Hi, any news about this feature ? Thanks i advance
Karl Dubost
Comment 14
Monday, March 20, 2023 1:36:18 AM UTC
https://wpt.fyi/results/audio-output/idlharness.https.window.html
https://wpt.live/audio-output/idlharness.https.window.html
Activating on STP Allow speaker device selection in Experimental features makes 3 more tests green. The 3 remaining are * MediaDevices interface: operation selectAudioOutput(optional AudioOutputOptions) * MediaDevices interface: navigator.mediaDevices must inherit property "selectAudioOutput(optional AudioOutputOptions)" with the proper type * MediaDevices interface: calling selectAudioOutput(optional AudioOutputOptions) on navigator.mediaDevices with too few arguments must throw TypeError
Karl Dubost
Comment 15
Monday, March 20, 2023 1:38:54 AM UTC
It also improves the results on
https://wpt.live/audio-output/setSinkId-permissions-policy.https.sub.html
Michael Hagar
Comment 16
Wednesday, January 24, 2024 3:33:07 PM UTC
Any update on this?
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug