Bug 216469 - [TestRunnerShared] Add a new class UIScriptControllerCommon to implement UIScriptController::windowIsKey and UIScriptController::setWindowIsKey
Summary: [TestRunnerShared] Add a new class UIScriptControllerCommon to implement UISc...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-13 19:50 PDT by Fujii Hironori
Modified: 2020-09-15 17:24 PDT (History)
10 users (show)

See Also:

Attachments
Patch (21.30 KB, patch)
2020-09-13 19:58 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Patch (25.04 KB, patch)
2020-09-13 21:20 PDT, Fujii Hironori 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (26.40 KB, patch)
2020-09-13 22:01 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Patch (26.49 KB, patch)
2020-09-14 13:33 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2020-09-13 19:50:46 PDT 
[TestRunnerShared] Make UIScriptController::windowIsKey and UIScriptController::setWindowIsKey virtual

I'd like to make TestRunnerShared as a standalone library which
doesn't depend on DRT and WTR (Bug 216465). Those methods were
added by r263979.
Comment 1 Fujii Hironori 2020-09-13 19:58:29 PDT 
Created attachment 408674 [details]
Patch
Comment 2 Fujii Hironori 2020-09-13 21:20:27 PDT 
Created attachment 408680 [details]
Patch
Comment 3 Fujii Hironori 2020-09-13 22:01:57 PDT 
Created attachment 408681 [details]
Patch
Comment 4 Fujii Hironori 2020-09-14 13:33:58 PDT 
Created attachment 408742 [details]
Patch
Comment 5 Darin Adler 2020-09-15 12:52:47 PDT 
Comment on attachment 408742 [details]
Patch

Seems OK. I have a huge patch with lots of simplifications to TestRunnerShared that I better land soon.
Comment 6 Fujii Hironori 2020-09-15 17:23:05 PDT 
Comment on attachment 408742 [details]
Patch

Clearing flags on attachment: 408742

Committed r267120: <https://trac.webkit.org/changeset/267120>
Comment 7 Fujii Hironori 2020-09-15 17:23:09 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2020-09-15 17:24:21 PDT 
<rdar://problem/68952059>