Bug 216440 – REGRESSION (r266817): ASSERTION FAILED: injectedBundle.isTestRunning() on imported/w3c/web-platform-tests/service-workers/service-worker/svg-target-reftest.https.html

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Alexey Proskuryakov]

imported/w3c/web-platform-tests/service-workers/service-worker/svg-target-reftest.https.html turned from a failure to pass on release, but it crashes with an assertion in debug consistently.

1   0x12ccd064c WTFCrash
2   0x14159b220 WTR::makeValueRefForValue(OpaqueJSContext const*, objc_object*)
3   0x1415df360 WTR::InjectedBundlePage::dump()
4   0x1415e4200 WTR::dumpAfterWaitAttributeIsRemoved(void*)

History: https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fservice-workers%2Fservice-worker%2Fsvg-target-reftest.https.html

Stack trace: https://build.webkit.org/results/Apple-Catalina-Debug-WK2-Tests/r266887%20(6555)/imported/w3c/web-platform-tests/service-workers/service-worker/svg-target-reftest.https-stderr.txt

[Darin Adler]

Can fix by adding:

    if (!testRunning)
        return;

To dumpAfterWaitAttributeIsRemoved.

[Darin Adler]

When I run this in the debugger, instead of a crash I get a hang.

[Darin Adler]

(In reply to Darin Adler from comment #2)
> When I run this in the debugger, instead of a crash I get a hang.

Oh, never mind, that’s because I was trying to run from a local file instead of with the WPT server.

[Darin Adler]

And service workers don’t work from local files.

[Darin Adler]

Created attachment 408606 [details]
Patch

[Darin Adler]

Created attachment 408612 [details]
Patch

[EWS Watchlist]

This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess

[EWS]

Committed r266984: <https://trac.webkit.org/changeset/266984>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 408612 [details].

[Radar WebKit Bug Importer]

<rdar://problem/68780801>