The following layout tests have become flaky failures on macOS release bots: compositing/tiling/tiled-mask-inwindow.html fast/events/page-visibility-iframe-move-test.html pageoverlay/overlay-remove-reinsert-view.html tiled-drawing/tiled-backing-in-window.html https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&test=compositing%2Ftiling%2Ftiled-mask-inwindow.html&test=fast%2Fevents%2Fpage-visibility-iframe-move-test.html&test=pageoverlay%2Foverlay-remove-reinsert-view.html&test=tiled-drawing%2Ftiled-backing-in-window.html
I was able to reproduce one of the failures with the following on r266634: run-webkit-tests compositing/tiling/tiled-mask-inwindow.html --iterations 100 --exit-after-n-failures 1 I could not reproduce with r266629.
<rdar://problem/68515242>
Not sure if this is fixed by the patch in https://bugs.webkit.org/show_bug.cgi?id=216261
Created attachment 408312 [details] Patch
Created attachment 408403 [details] Patch
Comment on attachment 408403 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408403&action=review > Source/WebKit/ChangeLog:10 > + transation is committed in UI process. To make sure web process picks up the changes, we need to invoke the typo: "transition" > Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:357 > +- (void)_doAfterActivityStateUpdate:(void (^)(void))completionHandler WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA)); Why is this not in WKWebViewPrivateForTesting.h?
Comment on attachment 408403 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408403&action=review > LayoutTests/fast/events/page-visibility-iframe-move-test.html:58 > + debug("VisibilityChanage event is received"); typo: "VisibilityChange"
Comment on attachment 408403 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408403&action=review >> Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:357 >> +- (void)_doAfterActivityStateUpdate:(void (^)(void))completionHandler WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA)); > > Why is this not in WKWebViewPrivateForTesting.h? ah, will move it to WKWebViewPrivateForTesting.h!
Created attachment 408415 [details] Patch
Comment on attachment 408415 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408415&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h:79 > +- (void)_doAfterActivityStateUpdate:(void (^)(void))completionHandler; Nice!
Committed r266847: <https://trac.webkit.org/changeset/266847> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408415 [details].