Bug 216258 - REGRESSION(r266634): WKThumbnailViewResetsViewStateWhenUnparented is flaky
Summary: REGRESSION(r266634): WKThumbnailViewResetsViewStateWhenUnparented is flaky
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sihui Liu
URL:
Keywords: InRadar
: 216263 (view as bug list)
Depends on: 216275
Blocks:
  Show dependency tree / graph
 
Reported: 2020-09-07 19:33 PDT by Sihui Liu
Modified: 2020-09-11 11:30 PDT (History)
5 users (show)

See Also:

Attachments
Patch (6.11 KB, patch)
2020-09-07 19:38 PDT, Sihui Liu 		no flags Details | Formatted Diff | Diff
Patch (7.67 KB, patch)
2020-09-07 19:49 PDT, Sihui Liu 		no flags Details | Formatted Diff | Diff
Patch (3.11 KB, patch)
2020-09-10 09:59 PDT, Sihui Liu 		no flags Details | Formatted Diff | Diff
Patch for landing (3.15 KB, patch)
2020-09-10 12:52 PDT, Sihui Liu 		no flags Details | Formatted Diff | Diff
Patch for landing (3.10 KB, patch)
2020-09-11 09:19 PDT, Sihui Liu 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sihui Liu 2020-09-07 19:33:10 PDT 
...
Comment 1 Sihui Liu 2020-09-07 19:38:50 PDT 
Created attachment 408204 [details]
Patch
Comment 2 Sihui Liu 2020-09-07 19:49:31 PDT 
Created attachment 408205 [details]
Patch
Comment 3 Sihui Liu 2020-09-08 07:47:41 PDT 
*** Bug 216263 has been marked as a duplicate of this bug. ***
Comment 4 Ryan Haddad 2020-09-08 10:58:43 PDT 
<rdar://problem/68515242>
Comment 5 Radar WebKit Bug Importer 2020-09-08 10:58:59 PDT 
<rdar://problem/68517951>
Comment 6 Sihui Liu 2020-09-09 09:07:11 PDT 
Mark this as blocked by 216275 as this could use the SPI introduced there.
Comment 7 Sihui Liu 2020-09-10 09:59:10 PDT 
Created attachment 408454 [details]
Patch
Comment 8 Sihui Liu 2020-09-10 12:52:59 PDT 
Created attachment 408469 [details]
Patch for landing
Comment 9 EWS 2020-09-10 13:32:53 PDT 
commit-queue failed to commit attachment 408469 [details] to WebKit repository.
Comment 10 Ryan Haddad 2020-09-10 18:05:19 PDT 
(In reply to EWS from comment #9)
> commit-queue failed to commit attachment 408469 [details] to WebKit
> repository.

Left an "oops" in the changelog :(
Comment 11 Tim Horton 2020-09-10 18:12:34 PDT 
(In reply to Ryan Haddad from comment #10)
> (In reply to EWS from comment #9)
> > commit-queue failed to commit attachment 408469 [details] to WebKit
> > repository.
> 
> Left an "oops" in the changelog :(

Also the changelog is all out of order, kinda seems like a mis-conflict-resolution or something
Comment 12 Sihui Liu 2020-09-11 09:19:32 PDT 
Created attachment 408537 [details]
Patch for landing
Comment 13 EWS 2020-09-11 09:54:17 PDT 
Committed r266927: <https://trac.webkit.org/changeset/266927>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 408537 [details].