Use of WebCore::RuntimeEnabledFeatures is almost always wrong as it is a global singleton that can be set by multiple different API layer preferences objects. Over the years, it has become convenient, as it "works" for settings that need to be accessed in non-page accessible places, but in reality, those are likely threading issues waiting to happen or layering violations due to use of RuntimeEnabledFeatures from the platform directory. See related, 215962 (Obsolete DeprecatedGlobalSettings)
The biggest thing to do here is likely adding a mechanism to extend WebCore::Settings (as generated from Settings.yaml) or a subset thereof, to work with Workers.
<rdar://problem/68714643>
Only able to find one incorrect include 'RuntimeEnabledFeatures' (using this search): https://searchfox.org/wubkat/source/PerformanceTests/DecoderTest/DecoderTest/main.mm#35 and https://searchfox.org/wubkat/source/PerformanceTests/DecoderTest/DecoderTest/main.mm#100 It also got consolidated here: https://github.com/WebKit/WebKit/commit/5ddb4127ac4e4a104338422e546a1cdc7b698769 @Tim - you reviewed above commit, do we need this bug to remain open? @Alexey - any help if Tim is not right contact?
CC'ing some folks who worked on feature flags recently.
Yeah RuntimeEnabledFeatures was removed. I'm going to repurpose this to be about removing the stale include Ahmad found.