Bug 215981 - Many settings in RuntimeEnabledSettings should autogenerated Settings: Part 1
Summary: Many settings in RuntimeEnabledSettings should autogenerated Settings: Part 1
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on: 215992
Blocks: 216182
  Show dependency tree / graph
 
Reported: 2020-08-29 17:12 PDT by Sam Weinig
Modified: 2020-09-04 09:31 PDT (History)
24 users (show)

See Also:

Attachments
Patch (163.87 KB, patch)
2020-08-29 17:23 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (162.98 KB, patch)
2020-08-29 17:38 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (163.19 KB, patch)
2020-08-29 17:39 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (163.55 KB, patch)
2020-08-29 18:08 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (159.04 KB, patch)
2020-08-30 19:19 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (158.88 KB, patch)
2020-08-31 10:36 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2020-08-29 17:12:20 PDT 
Many settings in RuntimeEnabledSettings should autogenerated Settings: Part 1
Comment 1 Sam Weinig 2020-08-29 17:23:39 PDT Comment hidden (obsolete)
Comment 2 Sam Weinig 2020-08-29 17:38:14 PDT Comment hidden (obsolete)
Comment 3 Sam Weinig 2020-08-29 17:39:49 PDT Comment hidden (obsolete)
Comment 4 Sam Weinig 2020-08-29 18:08:15 PDT Comment hidden (obsolete)
Comment 5 Sam Weinig 2020-08-30 16:18:24 PDT 
One of the test failures is due to EnableBySettings extended attributes on a partial interface not merging with EnabledBySettings extended attributes on the members of that partial interface. File https://bugs.webkit.org/show_bug.cgi?id=215992 to fix that.
Comment 6 Sam Weinig 2020-08-30 19:19:52 PDT 
Created attachment 407585 [details]
Patch
Comment 7 EWS 2020-08-31 09:38:32 PDT 
Tools/Scripts/svn-apply failed to apply attachment 407585 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 8 Sam Weinig 2020-08-31 10:36:03 PDT 
Created attachment 407610 [details]
Patch
Comment 9 EWS 2020-08-31 11:16:37 PDT 
Committed r266360: <https://trac.webkit.org/changeset/266360>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407610 [details].
Comment 10 Radar WebKit Bug Importer 2020-08-31 11:17:17 PDT 
<rdar://problem/68087637>