Bug 216100 – run-webkit-tests spends 20-30 seconds "building" ImageDiff

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: Tools / Tests

[Jonathan Bedard]

Tools/Scripts/build-imagediff --release

takes an inordinate amount of time for a null build (20-30 seconds), and run-webkit-tests calls it on every invocation, even if you pass --no-build.

This is 40-50% of the time it takes to run-webkit-tests a single test in the iOS simulator, and thus would wildly increase the turnaround rate when developing a test.

[Jonathan Bedard]

<rdar://problem/68232690>

[Jonathan Bedard]

Created attachment 407819 [details]
Patch

[Tim Horton]

Comment on attachment 407819 [details]
Patch

Won't _path_to_image_diff (which is @memoize'd) store the failure to find it in check_image_diff, and return that after we build it (thus making ImageDiff not found if it got built)?

[Jonathan Bedard]

(In reply to Tim Horton from comment #3)
> Comment on attachment 407819 [details]
> Patch
> 
> Won't _path_to_image_diff (which is @memoize'd) store the failure to find it
> in check_image_diff, and return that after we build it (thus making
> ImageDiff not found if it got built)?

Likely yes, the right solution is probably to clear out the memoization, but our current @memoize doesn't support that

[Alexey Proskuryakov]

Isn't bug 204420 the root cause here?

[Tim Horton]

(In reply to Alexey Proskuryakov from comment #5)
> Isn't bug 204420 the root cause here?

Do you mean "isn't this a dupe of that"? I think the answer is "yes"!

[Darin Adler]

*** This bug has been marked as a duplicate of bug 204420 ***