Bug 204420 - run-webkit-tests rebuilds ImageDiff every time
Summary: run-webkit-tests rebuilds ImageDiff every time
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
: 216100 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-11-20 13:06 PST by Alexey Proskuryakov
Modified: 2020-09-04 14:44 PDT (History)
6 users (show)

See Also:

Attachments
Patch (5.59 KB, patch)
2020-09-04 13:26 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2019-11-20 13:06:40 PST 
Every time I run run-webkit-tests --ios-simulator, I get this error, and ImageDiff gets rebuilt.

12:52:45.307 72842 Checking build ...
12:52:45.309 72842 ImageDiff was not found at /Users/ap/Safari/OpenSource/WebKitBuild/Release-iphonesimulator/ImageDiff

This path is incorrect, as ImageDiff is not a simulator project, it's built into Release/ImageDiff
Comment 1 Darin Adler 2020-09-02 21:20:44 PDT 
*** Bug 216100 has been marked as a duplicate of this bug. ***
Comment 2 Darin Adler 2020-09-02 21:21:27 PDT 
<rdar://problem/68232690>
Comment 3 Jonathan Bedard 2020-09-04 13:26:59 PDT 
Created attachment 408015 [details]
Patch
Comment 4 Jonathan Bedard 2020-09-04 13:30:29 PDT 
Comment on attachment 408015 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408015&action=review

> Tools/Scripts/webkitpy/port/base.py:278
> +        image_diff_path = self._path_to_image_diff()

Tim Horton's original point that _path_to_image_diff is memoized, is true, kind of, but not for Apple's ports. We really need to memoize _path_to_image_diff in all children classes, and then explicitly clear the memoization after building.
Comment 5 EWS 2020-09-04 14:44:33 PDT 
Committed r266638: <https://trac.webkit.org/changeset/266638>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 408015 [details].