Bug 216053 - [ANGLE] InternalFormat::blendSupport is uninitialized by constructor
Summary: [ANGLE] InternalFormat::blendSupport is uninitialized by constructor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: ANGLE (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-01 14:09 PDT by David Kilzer (:ddkilzer)
Modified: 2020-09-01 18:55 PDT (History)
11 users (show)

See Also:

Attachments
Patch v1 (2.65 KB, patch)
2020-09-01 14:11 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2020-09-01 14:09:28 PDT 
InternalFormat::blendSupport is uninitialized by its constructor.

Found by clang static analyzer using the optin.cplusplus.UninitializedObject checker.
Comment 1 Radar WebKit Bug Importer 2020-09-01 14:09:42 PDT 
<rdar://problem/68166032>
Comment 2 David Kilzer (:ddkilzer) 2020-09-01 14:11:14 PDT 
Created attachment 407713 [details]
Patch v1
Comment 3 EWS Watchlist 2020-09-01 14:11:45 PDT 
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Comment 4 Kenneth Russell 2020-09-01 14:12:52 PDT 
CC'ing ANGLE team members - likely want this to be upstreamed to ANGLE.
Comment 5 Kenneth Russell 2020-09-01 14:13:48 PDT 
Comment on attachment 407713 [details]
Patch v1

Looks good to me.
Comment 6 David Kilzer (:ddkilzer) 2020-09-01 14:14:43 PDT 
Regressed in WebKit tree with Bug 206318 with commit r255782, which itself was a mere from upstream ANGLE.
Comment 7 David Kilzer (:ddkilzer) 2020-09-01 14:17:34 PDT 
(In reply to Kenneth Russell from comment #4)
> CC'ing ANGLE team members - likely want this to be upstreamed to ANGLE.

Filed to track upstream:  <https://bugs.chromium.org/p/angleproject/issues/detail?id=5008>
Comment 8 David Kilzer (:ddkilzer) 2020-09-01 18:47:20 PDT 
Comment on attachment 407713 [details]
Patch v1

Marking cq+ since ios-wk2 is failing due to a progression, mac-debug-wk1 has 19 scheduled test runs queued, and all other tests passed.
Comment 9 EWS 2020-09-01 18:55:35 PDT 
Committed r266445: <https://trac.webkit.org/changeset/266445>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407713 [details].