Bug 206318 - Update ANGLE
Summary: Update ANGLE
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: ANGLE (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Darpinian
URL:
Keywords: InRadar
Depends on: 207080
Blocks: webglangle 205483 206625
  Show dependency tree / graph
 
Reported: 2020-01-15 15:14 PST by James Darpinian
Modified: 2020-03-11 17:12 PDT (History)
15 users (show)

See Also:

Attachments
Update ANGLE (7.04 MB, patch)
2020-01-15 15:36 PST, James Darpinian 		no flags Details | Formatted Diff | Diff
rebase (7.04 MB, patch)
2020-01-15 16:34 PST, James Darpinian 		dino: review+
Details | Formatted Diff | Diff
Update ANGLE again (7.98 MB, patch)
2020-02-04 14:12 PST, James Darpinian 		dino: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Darpinian 2020-01-15 15:14:29 PST 
Update ANGLE
Comment 1 James Darpinian 2020-01-15 15:36:12 PST 
Created attachment 387857 [details]
Update ANGLE
Comment 2 James Darpinian 2020-01-15 16:34:12 PST 
Created attachment 387866 [details]
rebase
Comment 3 EWS Watchlist 2020-01-15 16:37:58 PST 
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Comment 4 Dean Jackson 2020-01-22 15:07:04 PST 
I will land in a moment.
Comment 5 Dean Jackson 2020-01-23 10:26:20 PST 
Committed r254981: <https://trac.webkit.org/changeset/254981>
Comment 6 Radar WebKit Bug Importer 2020-01-23 10:27:19 PST 
<rdar://problem/58839342>
Comment 7 Dean Jackson 2020-01-29 16:45:45 PST 
Committed r255403: <https://trac.webkit.org/changeset/255403>
Comment 8 James Darpinian 2020-01-31 16:31:35 PST 
Reverted again in r255410 due to continuing test failures. I have found the root cause in bug	207080.
Comment 9 James Darpinian 2020-02-04 14:12:21 PST 
Created attachment 389707 [details]
Update ANGLE again
Comment 10 Dean Jackson 2020-02-04 16:41:17 PST 
Comment on attachment 389707 [details]
Update ANGLE again

rs=me

I will land now.
Comment 11 Dean Jackson 2020-02-04 18:03:08 PST 
Committed r255782: <https://trac.webkit.org/changeset/255782>
Comment 12 Michael Catanzaro 2020-02-10 10:26:26 PST 
(In reply to Build Bot from comment #3)
> Note that there are important steps to take when updating ANGLE. See
> http://trac.webkit.org/wiki/UpdatingANGLE

Looks like some steps from this wiki page are obsolete? Steps 3 through 6? OK for me to remove those from the wiki page? I'll also add a step mentioning the need to maintain changes.diff.
Comment 13 James Darpinian 2020-02-10 14:55:56 PST 
Yes, please do update the wiki, I don't have permission. All of the steps there are obsolete. The steps now are:

1. Run the script Source/ThirdParty/update-angle.sh and follow its instructions.

That's it. The script does a git rebase which automatically carries forward all existing modifications such as the license disclaimer mentioned in the old steps. It handles updating the plist file and the changes.diff file and even the CMake files, and it gives instructions for how to modify the XCode build. There are no other manual steps anymore.
Comment 14 James Darpinian 2020-02-10 14:57:05 PST 
Sorry, the actual path to the script is Source/ThirdParty/ANGLE/update-angle.sh
Comment 15 Michael Catanzaro 2020-02-11 08:41:13 PST 
OK thanks, new wiki page: https://trac.webkit.org/wiki/UpdatingANGLE