Right now the quotes property returns an empty string when getting it from getComputedStyle on WebKit-based browsers. That makes no sense (that's not a valid property value of course).
See https://github.com/w3c/csswg-drafts/issues/4074 for the CSSWG resolution to name this value "auto". Firefox implements this since ages ago, and there are WPTs for this.
Created attachment 407049 [details]
Created attachment 407051 [details]
Comment on attachment 407051 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=407051&action=review
Patch looks good, and I will review after we have the tests uploaded and the EWS applies and confirms things are working.
> +static Ref<CSSValue>valueForQuotes(const QuotesData* quotes)
Missing space after ">".
Created attachment 407060 [details]
(In reply to Darin Adler from comment #3)
> Missing space after ">".
Thanks, done :)
Created attachment 407061 [details]
Created attachment 407075 [details]
Comment on attachment 407075 [details]
I did a grep, and all of these files have "quotes: ;" in them that have to be changed to "quotes: auto;"
So the patch needs to include changes to all 4 of the files. And they need to be mentioned in the change log.
Gah, thanks, I did update that test but didn't realize that the baselines were platform specific.
Created attachment 407077 [details]
(In reply to Emilio Cobos Álvarez (:emilio) from comment #9)
> Gah, thanks, I did update that test but didn't realize that the baselines
> were platform specific.
I am not sure why those platform specific results have to exist. Might be removable with a little research. But obviously easiest to just update them in the short term.
Will review as soon as we get green EWS results.
(In reply to Darin Adler from comment #11)
> (In reply to Emilio Cobos Álvarez (:emilio) from comment #9)
> I am not sure why those platform specific results have to exist. Might be
> removable with a little research. But obviously easiest to just update them
> in the short term.
I guess there are different properties enabled on different ports, and this test accidentally lists all supported CSS properties. The good thing though is that EWS seems green now :)
Committed r266082: <https://trac.webkit.org/changeset/266082>
All reviewed patches have been landed. Closing bug and clearing flags on attachment 407077 [details].