Bug 215646 – The initial value of quotes should be auto.

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Emilio Cobos Álvarez (:emilio)]

Right now the quotes property returns an empty string when getting it from getComputedStyle on WebKit-based browsers. That makes no sense (that's not a valid property value of course).

See https://github.com/w3c/csswg-drafts/issues/4074 for the CSSWG resolution to name this value "auto". Firefox implements this since ages ago, and there are WPTs for this.

[Emilio Cobos Álvarez (:emilio)]

Created attachment 407049 [details]
Patch

[Emilio Cobos Álvarez (:emilio)]

Created attachment 407051 [details]
Patch

[Darin Adler]

Comment on attachment 407051 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407051&action=review

Patch looks good, and I will review after we have the tests uploaded and the EWS applies and confirms things are working.

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:477
> +static Ref<CSSValue>valueForQuotes(const QuotesData* quotes)

Missing space after ">".

[Emilio Cobos Álvarez (:emilio)]

Created attachment 407060 [details]
Patch

[Emilio Cobos Álvarez (:emilio)]

(In reply to Darin Adler from comment #3)
> Missing space after ">".

Thanks, done :)

[Emilio Cobos Álvarez (:emilio)]

Created attachment 407061 [details]
Patch

[Emilio Cobos Álvarez (:emilio)]

Created attachment 407075 [details]
Patch

[Darin Adler]

Comment on attachment 407075 [details]
Patch

I did a grep, and all of these files have "quotes: ;" in them that have to be changed to "quotes: auto;"

imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt
platform/gtk/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt
platform/ios-wk2/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt
platform/wpe/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt

So the patch needs to include changes to all 4 of the files. And they need to be mentioned in the change log.

[Emilio Cobos Álvarez (:emilio)]

Gah, thanks, I did update that test but didn't realize that the baselines were platform specific.

[Emilio Cobos Álvarez (:emilio)]

Created attachment 407077 [details]
Patch

[Darin Adler]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #9)
> Gah, thanks, I did update that test but didn't realize that the baselines
> were platform specific.

I am not sure why those platform specific results have to exist. Might be removable with a little research. But obviously easiest to just update them in the short term.

Will review as soon as we get green EWS results.

[Emilio Cobos Álvarez (:emilio)]

(In reply to Darin Adler from comment #11)
> (In reply to Emilio Cobos Álvarez (:emilio) from comment #9)
> I am not sure why those platform specific results have to exist. Might be
> removable with a little research. But obviously easiest to just update them
> in the short term.

I guess there are different properties enabled on different ports, and this test accidentally lists all supported CSS properties. The good thing though is that EWS seems green now :)

[EWS]

Committed r266082: <https://trac.webkit.org/changeset/266082>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407077 [details].

[Radar WebKit Bug Importer]

<rdar://problem/67692693>