Bug 215751 - Import css-content tests.
Summary: Import css-content tests.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Emilio Cobos Álvarez (:emilio)
URL:
Keywords: InRadar
Depends on:
Blocks: 215646
  Show dependency treegraph
 
Reported: 2020-08-22 06:30 PDT by Emilio Cobos Álvarez (:emilio)
Modified: 2020-08-22 15:46 PDT (History)
9 users (show)

See Also:


Attachments
Patch (169.04 KB, patch)
2020-08-22 06:55 PDT, Emilio Cobos Álvarez (:emilio)
no flags Details | Formatted Diff | Diff
Patch for landing (118.53 KB, patch)
2020-08-22 14:56 PDT, Emilio Cobos Álvarez (:emilio)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Emilio Cobos Álvarez (:emilio) 2020-08-22 06:30:37 PDT
.
Comment 1 Emilio Cobos Álvarez (:emilio) 2020-08-22 06:55:39 PDT
Created attachment 407050 [details]
Patch
Comment 2 EWS 2020-08-22 14:09:57 PDT
Tools/Scripts/svn-apply failed to apply attachment 407050 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 3 Emilio Cobos Álvarez (:emilio) 2020-08-22 14:40:43 PDT
It seems import-w3c-tests generates different output when ran under python2 vs. python3 (ugh!).

That causes a bunch of whitespace changes in the import-expectations.json file, that caused my patch to conflict with trunk.

I'll send the same patch, but generated with python2 rather than python3, as that seems to be what people are using.
Comment 4 Emilio Cobos Álvarez (:emilio) 2020-08-22 14:56:58 PDT
Created attachment 407057 [details]
Patch for landing
Comment 5 EWS 2020-08-22 15:45:53 PDT
Committed r266038: <https://trac.webkit.org/changeset/266038>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407057 [details].
Comment 6 Radar WebKit Bug Importer 2020-08-22 15:46:23 PDT
<rdar://problem/67625320>