Bug 215616 - [WebGL2] Various parameters should be non-nullable in IDL
Summary: [WebGL2] Various parameters should be non-nullable in IDL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Darpinian
URL:
Keywords: InRadar
Depends on:
Blocks: 126404
  Show dependency treegraph
 
Reported: 2020-08-18 11:10 PDT by James Darpinian
Modified: 2020-08-18 16:50 PDT (History)
13 users (show)

See Also:


Attachments
Patch (69.70 KB, patch)
2020-08-18 11:13 PDT, James Darpinian
no flags Details | Formatted Diff | Diff
Patch (95.95 KB, patch)
2020-08-18 14:55 PDT, James Darpinian
no flags Details | Formatted Diff | Diff
Patch (108.68 KB, patch)
2020-08-18 15:26 PDT, James Darpinian
no flags Details | Formatted Diff | Diff
Patch (120.88 KB, patch)
2020-08-18 16:01 PDT, James Darpinian
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Darpinian 2020-08-18 11:10:42 PDT
[WebGL2] Various parameters should be non-nullable in IDL
Comment 1 James Darpinian 2020-08-18 11:13:54 PDT
Created attachment 406794 [details]
Patch
Comment 2 Kenneth Russell 2020-08-18 14:34:40 PDT
Comment on attachment 406794 [details]
Patch

The patch looks good but some tests are failing. Could you resolve those failures and ping when there's a new patch up? Thanks.
Comment 3 James Darpinian 2020-08-18 14:55:43 PDT
Created attachment 406815 [details]
Patch
Comment 4 James Darpinian 2020-08-18 15:26:20 PDT
Created attachment 406818 [details]
Patch
Comment 5 James Darpinian 2020-08-18 15:27:59 PDT
Lots of wrong and broken tests needed fixing. I think this patch should pass now.
Comment 6 Darin Adler 2020-08-18 15:35:20 PDT
Comment on attachment 406818 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406818&action=review

> LayoutTests/ChangeLog:17
> +        * fast/canvas/webgl/context-lost-expected.txt:
> +        * fast/canvas/webgl/context-lost.html:
> +        * fast/canvas/webgl/error-reporting-expected.txt:
> +        * fast/canvas/webgl/error-reporting.html:
> +        * fast/canvas/webgl/get-active-test-expected.txt:
> +        * fast/canvas/webgl/get-active-test.html:
> +        * fast/canvas/webgl/gl-object-get-calls-expected.txt:
> +        * fast/canvas/webgl/gl-object-get-calls.html:
> +        * fast/canvas/webgl/null-object-behaviour-expected.txt:
> +        * fast/canvas/webgl/null-object-behaviour.html:

If any of these are redundant tests, you should feel free to cut them down.
Comment 7 Darin Adler 2020-08-18 15:35:48 PDT
Oops, I didn’t wait long enough to see if the tests pass. Please don’t land until you know they pass.
Comment 8 Kenneth Russell 2020-08-18 15:38:25 PDT
Comment on attachment 406818 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406818&action=review

Fantastic work James! One question.

> LayoutTests/fast/canvas/webgl/error-reporting.html:-21
> -// synthetic GL errors. This test verifies the raising of certain

Was the removal of this part of the comment intentional?
Comment 9 James Darpinian 2020-08-18 15:48:21 PDT
Comment on attachment 406818 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406818&action=review

>> LayoutTests/ChangeLog:17
>> +        * fast/canvas/webgl/null-object-behaviour.html:
> 
> If any of these are redundant tests, you should feel free to cut them down.

Thanks, yes, they are redundant to some in webgl/1.0.3 and webgl/2.0.0. Next time I'll try deleting redundant tests instead of attempting to fix them.

>> LayoutTests/fast/canvas/webgl/error-reporting.html:-21
>> -// synthetic GL errors. This test verifies the raising of certain
> 
> Was the removal of this part of the comment intentional?

You're right, this was unintentional.
Comment 10 James Darpinian 2020-08-18 15:55:51 PDT
Comment on attachment 406818 [details]
Patch

Looks like I missed rebaselining two tests.
Comment 11 James Darpinian 2020-08-18 16:01:25 PDT
Created attachment 406820 [details]
Patch
Comment 12 Kenneth Russell 2020-08-18 16:18:28 PDT
Comment on attachment 406820 [details]
Patch

Looks good! r+
Comment 13 EWS 2020-08-18 16:49:28 PDT
Committed r265841: <https://trac.webkit.org/changeset/265841>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406820 [details].
Comment 14 Radar WebKit Bug Importer 2020-08-18 16:50:15 PDT
<rdar://problem/67362134>