Bug 215349 – Clean up DragApplicationFlags after switch to OptionSet<>

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[David Kilzer (:ddkilzer)]

Bug 215341 fixed a WebContent crash, but there are a couple things to clean up:

1. DragApplicationFlags::DragApplicationNone can be removed.
2. DragApplicationFlags should be an enum class so DragApplicationFlags::DragApplicationIsModal becomes DragApplicationFlags::IsModal.
3. -[WebView applicationFlags:] should return an OptionSet<WebCore::DragApplicationFlags>.  (Fix call sites that use it.)
4. Source/WebKit/UIProcess/API/gtk/DropTargetGtk3.cpp should use OptionSet<WebCore::DragApplicationFlags> within the function.

[David Kilzer (:ddkilzer)]

(In reply to David Kilzer (:ddkilzer) from comment #0)
> Bug 215341 fixed a WebContent crash, but there are a couple things to clean
> up:
> 
> 1. DragApplicationFlags::DragApplicationNone can be removed.

Chris already fixed this in Bug 215341.

[David Kilzer (:ddkilzer)]

Created attachment 406644 [details]
Patch v1

[EWS Watchlist]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[David Kilzer (:ddkilzer)]

Created attachment 406667 [details]
Patch v2

[Darin Adler]

Comment on attachment 406667 [details]
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=406667&action=review

Seems like a GTK test related to the patch failed. I pushed the retry button so it would try again.

> Source/WebCore/platform/DragData.h:61
> +enum class DragApplicationFlags : uint8_t {

The enum represents a single flag. Doesn’t make sense to call it "flags". An OptionSet, of course, contains multiple flags. So this should be renamed DragApplicationFlag, singular.

[David Kilzer (:ddkilzer)]

Comment on attachment 406667 [details]
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=406667&action=review

>> Source/WebCore/platform/DragData.h:61
>> +enum class DragApplicationFlags : uint8_t {
> 
> The enum represents a single flag. Doesn’t make sense to call it "flags". An OptionSet, of course, contains multiple flags. So this should be renamed DragApplicationFlag, singular.

I'm assuming this can be done in a separate patch.

[EWS]

Committed r265756: <https://trac.webkit.org/changeset/265756>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406667 [details].

[Radar WebKit Bug Importer]

<rdar://problem/67250771>