Bug 215341 – AuxiliaryProcess::didReceiveInvalidMessage() for WebPage::PerformDragControllerAction IPC

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

AuxiliaryProcess::didReceiveInvalidMessage() for WebPage::PerformDragControllerAction IPC.

[Chris Dumez]

<rdar://problem/59344091>

[Chris Dumez]

Created attachment 406335 [details]
Patch

[Chris Dumez]

Created attachment 406339 [details]
Patch

[Chris Dumez]

Created attachment 406341 [details]
Patch

[Chris Dumez]

Working on getting GTK/WPE building

[Wenson Hsieh]

Comment on attachment 406341 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406341&action=review

> Tools/TestWebKitAPI/Tests/mac/DragAndDropTestsMac.mm:151
> +    return [NSEvent mouseEventWithType:NSEventTypeLeftMouseDragged
> +                location:NSMakePoint(0, 200)
> +           modifierFlags:NSEventModifierFlagOption
> +               timestamp:[NSDate timeIntervalSinceReferenceDate]
> +            windowNumber:0
> +                 context:nil
> +             eventNumber:1
> +              clickCount:1
> +                pressure:1];

(Minor style nit - we should either make this all 1 line, or left align all the parameters)

[Chris Dumez]

Created attachment 406344 [details]
Patch

[David Kilzer (:ddkilzer)]

Comment on attachment 406344 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406344&action=review

> Source/WebCore/platform/DragData.h:62
>      DragApplicationNone = 0,

Darin insisted I remove the "None" enums when switching to use OptionSet<>.  We don't need to do that for this patch, but I'll look at doing it as a follow-up (and covert DragApplicationFlags to an enum class).

[Chris Dumez]

Created attachment 406345 [details]
Patch

[EWS]

Committed r265480: <https://trac.webkit.org/changeset/265480>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406345 [details].