Bug 215298 - Off by one error in transform feedback buffer binding
Summary: Off by one error in transform feedback buffer binding
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Darpinian
URL:
Keywords: InRadar
Depends on:
Blocks: 126404
  Show dependency treegraph
 
Reported: 2020-08-07 16:04 PDT by James Darpinian
Modified: 2020-08-07 17:39 PDT (History)
10 users (show)

See Also:


Attachments
Patch (1.58 KB, patch)
2020-08-07 16:05 PDT, James Darpinian
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Darpinian 2020-08-07 16:04:06 PDT
Off by one error in transform feedback buffer binding
Comment 1 James Darpinian 2020-08-07 16:05:17 PDT
Created attachment 406224 [details]
Patch
Comment 2 Kenneth Russell 2020-08-07 16:07:09 PDT
Comment on attachment 406224 [details]
Patch

Looks good to me. I'd r+ but my reviewer status hasn't been reinstated.
Comment 3 Chris Dumez 2020-08-07 16:08:00 PDT
Comment on attachment 406224 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406224&action=review

> Source/WebCore/ChangeLog:8
> +        Caught by conformance test deqp/functional/gles3/negativebufferapi.html

This change is missing a test.
Comment 4 James Darpinian 2020-08-07 16:19:27 PDT
Comment on attachment 406224 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406224&action=review

>> Source/WebCore/ChangeLog:8
>> +        Caught by conformance test deqp/functional/gles3/negativebufferapi.html
> 
> This change is missing a test.

The test is present. The suite it's in (deqp) is currently skipped in the test expectations because it takes a long time to run. I'm looking into whether we can make it faster.
Comment 5 Dean Jackson 2020-08-07 16:31:48 PDT
Comment on attachment 406224 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406224&action=review

>>> Source/WebCore/ChangeLog:8
>>> +        Caught by conformance test deqp/functional/gles3/negativebufferapi.html
>> 
>> This change is missing a test.
> 
> The test is present. The suite it's in (deqp) is currently skipped in the test expectations because it takes a long time to run. I'm looking into whether we can make it faster.

We have a separate bot that runs the deqp tests.
Comment 6 EWS 2020-08-07 16:56:34 PDT
Committed r265399: <https://trac.webkit.org/changeset/265399>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406224 [details].
Comment 7 Radar WebKit Bug Importer 2020-08-07 16:57:18 PDT
<rdar://problem/66706728>