Bug 215174 – EWS emails about build failure should include relevant error logs

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Aakash Jain]

EWS emails about build failure should include relevant error logs. It would make it easier to quickly identify the issue from the email itself.

These logs will be filtered/shortened version of error logs which are displayed in Buildbot build (which were added in Bug 203418).

Currently these emails are enabled only for bot-watchers, but when we will enable them for engineers, having relevant error logs in email would be useful.

[Aakash Jain]

Created attachment 406012 [details]
Patch

[Aakash Jain]

Tested in https://ews-build.webkit-uat.org/#/builders/33/builds/274

[Jonathan Bedard]

Comment on attachment 406012 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406012&action=review

> Tools/BuildSlaveSupport/ews-build/steps.py:-1398
> -        return defer.succeed(None)

Was this line removed intentionally?

> Tools/BuildSlaveSupport/ews-build/steps.py:1408
> +    def getResults(self, name):

What is the return value of this function? I ask because it looks like @defer.inlineCallbacks is overriding that.

> Tools/BuildSlaveSupport/ews-build/steps.py:1411
> +            defer.returnValue(None)

This looks like an early exit, but I'm not familiar with this 'defer' idiom, do we not need to return so we exit early?

[Aakash Jain]

Comment on attachment 406012 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406012&action=review

>> Tools/BuildSlaveSupport/ews-build/steps.py:-1398
>> -        return defer.succeed(None)
> 
> Was this line removed intentionally?

Yes, it was moved. This line belonged to start() method earlier, and now also it belongs to start() method.

>> Tools/BuildSlaveSupport/ews-build/steps.py:1411
>> +            defer.returnValue(None)
> 
> This looks like an early exit, but I'm not familiar with this 'defer' idiom, do we not need to return so we exit early?

Yes. Also this method is mostly copied from AnalyzeAPITestsResults::getTestsResults()

[Aakash Jain]

Created attachment 406026 [details]
Patch

[EWS]

Committed r265302: <https://trac.webkit.org/changeset/265302>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406026 [details].

[Radar WebKit Bug Importer]

<rdar://problem/66591524>