The EWS results presented when you click on a failure bubble currently gives you the option of looking at warnings, or looking at the entire log file (which can be tens of thousands of lines). We should also offer a filtered "errors" view that only shows the compile errors. These are generally the most important things to look at. Warnings are generally not as useful for figuring out why an EWS bot is unhappy.
Created attachment 381929 [details] Current view Here's a screenshot showing the two options. A much better tool would be a summary of the compiler errors.
You might consider passing the output through Dino's old "filter-build-webkit" script, which did a good job of culling out boilerplate noise, and showing only the meaningful output from a compile.
<rdar://problem/56619679>
Created attachment 381950 [details] Patch
Sample runs: https://ews-build.webkit-uat.org/#/builders/3/builds/102/steps/7/logs/errors https://ews-build.webkit-uat.org/#/builders/3/builds/101/steps/7/logs/errors
Comment on attachment 381950 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381950&action=review > Tools/BuildSlaveSupport/ews-build/steps.py:747 > + is_whitespace = self.whitespace_re.search(line) is not None This temporary variable doesn't seem super useful > Tools/BuildSlaveSupport/ews-build/steps.py:754 > + map(self.errorReceived, self.error_context_buffer[:-1]) Why the -1? Couldn't we just map errorReceived to the whole buffer, which would include the line?
(In reply to Aakash Jain from comment #4) > Created attachment 381950 [details] > Patch Oh gosh! I'm so happy! :-)
(In reply to Jonathan Bedard from comment #6) > Why the -1? Couldn't we just map errorReceived to the whole buffer, which would include the line? Changed in updated patch.
Created attachment 381957 [details] Patch
Sample runs: https://ews-build.webkit-uat.org/#/builders/3/builds/109 https://ews-build.webkit-uat.org/#/builders/3/builds/110
(In reply to Aakash Jain from comment #10) > Sample runs: > https://ews-build.webkit-uat.org/#/builders/3/builds/109 > https://ews-build.webkit-uat.org/#/builders/3/builds/110 These look great!
Committed r251604: <https://trac.webkit.org/changeset/251604>
Deployed on the production server.
Created attachment 382076 [details] Screenshot - view after this change From https://ews-build.webkit.org/#/builders/16/builds/6054
*** Bug 201941 has been marked as a duplicate of this bug. ***