Bug 215036 - [WebGL2] Upgrade vertexAttribPointer with new supported types
Summary: [WebGL2] Upgrade vertexAttribPointer with new supported types
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Darpinian
URL:
Keywords: InRadar
Depends on: 126938 214211
Blocks: 126404
  Show dependency treegraph
 
Reported: 2020-07-31 15:14 PDT by Kenneth Russell
Modified: 2020-08-05 18:59 PDT (History)
9 users (show)

See Also:


Attachments
Patch (2.66 KB, patch)
2020-08-03 16:55 PDT, James Darpinian
no flags Details | Formatted Diff | Diff
Patch (2.87 KB, patch)
2020-08-03 17:28 PDT, James Darpinian
no flags Details | Formatted Diff | Diff
add tests (12.02 KB, patch)
2020-08-05 17:44 PDT, James Darpinian
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2020-07-31 15:14:42 PDT
Based on some feedback from the Filament team, and examining WebGLRenderingContextBase::vertexAttribPointer (which isn't overridden in WebGL2RenderingContext), it looks like vertexAttribPointer needs to be upgraded to support the new types in WebGL 2.0 / OpenGL ES 3.0.
Comment 1 Kenneth Russell 2020-07-31 15:30:00 PDT
When this is fixed, let's make sure to test with the Filament team's test case to see whether it's working.
Comment 2 James Darpinian 2020-08-03 16:55:06 PDT
Created attachment 405886 [details]
Patch
Comment 3 James Darpinian 2020-08-03 16:57:19 PDT
This doesn't appear to be tested at all by the conformance tests as far as I can tell. I'm working on adding some tests.
Comment 4 James Darpinian 2020-08-03 17:28:48 PDT
Created attachment 405894 [details]
Patch
Comment 5 James Darpinian 2020-08-03 17:37:32 PDT
Confirmed that this fixes the Filament test case :)
Comment 6 Kenneth Russell 2020-08-04 12:42:37 PDT
Comment on attachment 405894 [details]
Patch

Looks good!
Comment 7 Dean Jackson 2020-08-04 12:50:18 PDT
Comment on attachment 405894 [details]
Patch

Can we get a test (or WebGL conformance test) for this?
Comment 8 Dean Jackson 2020-08-04 12:50:48 PDT
Comment on attachment 405894 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405894&action=review

> Source/WebCore/ChangeLog:6
> +        Reviewed by NOBODY (OOPS!).

Please note here that a test is coming in the WebGL suite.
Comment 9 James Darpinian 2020-08-05 17:44:43 PDT
Created attachment 406062 [details]
add tests
Comment 10 James Darpinian 2020-08-05 17:45:38 PDT
Comment on attachment 406062 [details]
add tests

I went ahead and updated the conformance tests.
Comment 11 Kenneth Russell 2020-08-05 18:41:06 PDT
Comment on attachment 406062 [details]
add tests

Looks good - thanks for patching up the conformance tests James!
Comment 12 EWS 2020-08-05 18:58:14 PDT
Committed r265317: <https://trac.webkit.org/changeset/265317>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406062 [details].
Comment 13 Radar WebKit Bug Importer 2020-08-05 18:59:18 PDT
<rdar://problem/66604955>