Bug 21497 - REGRESSION (r37433): Bytecode JSC tests are severely broken
Summary: REGRESSION (r37433): Bytecode JSC tests are severely broken
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Cameron Zwarich (cpst)
URL:
Keywords: Regression
Depends on:
Blocks:
 
Reported: 2008-10-08 22:19 PDT by Cameron Zwarich (cpst)
Modified: 2008-10-09 00:12 PDT (History)
1 user (show)

See Also:


Attachments
Proposed patch (1.25 KB, patch)
2008-10-08 22:25 PDT, Cameron Zwarich (cpst)
mjs: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron Zwarich (cpst) 2008-10-08 22:19:01 PDT
There is a typo in r37433 that leads to a significant number of JSC test failures when using the bytecode interpreter. I can't finish running the tests without quitting and continuing the driver after each one. I unfortunately figured this out while spending a few hours reducing and chasing down bug 21459 in bytecode.
Comment 1 Cameron Zwarich (cpst) 2008-10-08 22:25:47 PDT
Created attachment 24222 [details]
Proposed patch
Comment 2 Maciej Stachowiak 2008-10-08 22:26:27 PDT
Comment on attachment 24222 [details]
Proposed patch

r=me
Comment 3 Cameron Zwarich (cpst) 2008-10-08 22:31:03 PDT
Landed in r37441.
Comment 4 Darin Adler 2008-10-09 00:12:22 PDT
Oops. Sorry. Thanks!