Bug 214936 - Remove deprecated script and stylesheet injection SPI, replaced with more inclusively-named SPI
Summary: Remove deprecated script and stylesheet injection SPI, replaced with more inc...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks: 213092
  Show dependency tree / graph
 
Reported: 2020-07-29 14:38 PDT by Alex Christensen
Modified: 2021-01-13 14:40 PST (History)
2 users (show)

See Also:

Attachments
Patch (7.20 KB, patch)
2020-07-29 14:39 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2020-07-29 14:38:22 PDT 
Remove deprecated script and stylesheet injection SPI, replaced with more inclusively-named SPI
Comment 1 Alex Christensen 2020-07-29 14:39:27 PDT 
Created attachment 405504 [details]
Patch
Comment 2 Alex Christensen 2020-07-29 14:41:16 PDT 
Comment on attachment 405504 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405504&action=review

> Source/WebKitLegacy/mac/ChangeLog:8
> +        rdar://64376341 tracks the adoption of the replacement.  Once that is done, we can remove the old SPI.

Note: we will have to wait for this to be integrated before landing this, but feel free to review before then.
Comment 3 Radar WebKit Bug Importer 2020-08-05 14:39:19 PDT 
<rdar://problem/66594434>
Comment 4 EWS 2020-09-21 22:07:18 PDT 
Committed r267397: <https://trac.webkit.org/changeset/267397>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405504 [details].
Comment 5 Alex Christensen 2020-09-29 12:16:53 PDT 
Reverted r267397 for reason:

SPI is still used

Committed r267756: <https://trac.webkit.org/changeset/267756>
Comment 6 Alex Christensen 2020-09-29 12:19:46 PDT 
The problem mentioned in rdar://problem/66227777 also needs to be resolved before this can be re-landed.
Comment 7 Alex Christensen 2020-11-03 19:13:32 PST 
We unfortunately need to wait another 6 months or so before retrying this.
Comment 8 Alex Christensen 2021-01-13 14:40:52 PST 
http://trac.webkit.org/r271456