Bug 214889 – Migrate App-Bound Domains code from WebKit Additions

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Kate Cheney]

We should migrate some additional app-bound domains code to WebKit

[Kate Cheney]

rdar://problem/66075857

[Kate Cheney]

Created attachment 405399 [details]
Patch

[Kate Cheney]

Created attachment 405400 [details]
Patch

[Kate Cheney]

Created attachment 405402 [details]
Patch

[Kate Cheney]

Created attachment 405405 [details]
Patch

[Kate Cheney]

Created attachment 405406 [details]
Patch

[Kate Cheney]

Created attachment 405409 [details]
Patch

[Kate Cheney]

Created attachment 405411 [details]
Patch

[Kate Cheney]

Having some trouble making EWS happy, hopefully this one does it...

[Kate Cheney]

Created attachment 405414 [details]
Patch

[Kate Cheney]

Created attachment 405419 [details]
Patch

[Brent Fulgham]

Comment on attachment 405419 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405419&action=review

r=me, but please correct the ChangeLog that includes Ryan's description, too.

> Source/WebKit/Shared/Cocoa/DefaultWebBrowserChecks.mm:192
> +        @"NSRemindersUsageDescription",

Can you please remove the "NSRemindersUsageDescription", we are not restricting this one anymore.

> LayoutTests/ChangeLog:11
> +

Oops! Two ChangeLog entries.

[Kate Cheney]

(In reply to Brent Fulgham from comment #12)
> Comment on attachment 405419 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=405419&action=review
> 
> r=me, but please correct the ChangeLog that includes Ryan's description, too.
> 

Whoops -- accidentally absorbed that along the way. Will fix.

> > Source/WebKit/Shared/Cocoa/DefaultWebBrowserChecks.mm:192
> > +        @"NSRemindersUsageDescription",
> 

Yes, will do.

> Can you please remove the "NSRemindersUsageDescription", we are not
> restricting this one anymore.
> 
> > LayoutTests/ChangeLog:11
> > +
> 
> Oops! Two ChangeLog entries.

Good catch!

[Kate Cheney]

Created attachment 405422 [details]
Patch for landing

[EWS]

Committed r265018: <https://trac.webkit.org/changeset/265018>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405422 [details].

[Aakash Jain]

This (In reply to EWS from comment #15)
> Committed r265018: <https://trac.webkit.org/changeset/265018>
This seems to have broken various ios-wk2 tests. Tracked in Bug 214916. 

Please make sure to run the patches through EWS before landing. In this case there were 10 patches uploaded within ~2 hours, and none of the patches were run through ios-wk2, api-ios, mac-debug-wk1, win EWSes.

[WebKit Commit Bot]

Re-opened since this is blocked by bug 214917

[Kate Cheney]

Created attachment 405476 [details]
Patch

[Kate Cheney]

Thanks Aakash -- my bad on not letting EWS finish. I am unable to reproduce these failures locally, so I am uploading this patch with some logging to try and figure out what is going on on EWS.

[Kate Cheney]

Created attachment 405484 [details]
Patch

[Brent Fulgham]

Comment on attachment 405484 [details]
Patch

r=me

[EWS]

Committed r265063: <https://trac.webkit.org/changeset/265063>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405484 [details].