Bug 21483 – Regression: run-webkit-tests --pixel svg fails with diffs which aren't diffs

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Eric Seidel (no email)]

run-webkit-tests --pixel svg fails with diffs which aren't diffs

the perl script seems to get confused as to what's what.  It's spitting out png dumps as diffs and doing image diffs between the pixel results of the wrong two tests.  Something in the output stream from DRT must have gotten run-webkit-tests confused.

This is a regression as this used to work just fine.

[Simon Fraser (smfr)]

Fallout from bug 21124 and bug 21323

[Simon Fraser (smfr)]

Created attachment 24203 [details]
Patch, changelog

This patch changes DRT to print an ExpectPNG: line to the output when it knows it will spew out PNG data. The script can then look for this, rather than guessing. It also adds a little Content-Type checking.

[Eric Seidel (no email)]

Comment on attachment 24203 [details]
Patch, changelog

Looks fine.

[Simon Fraser (smfr)]

Created attachment 24210 [details]
Alternate solution

This second patch makes DRT always dump two #EOF-terminated blocks; the second, for PNG data, may be empty.

Comment on attachment 24210 [details]
Alternate solution

r=me, assuming you tested in the various scenarios (--pixel, --pixel with no existing results, tests that dump as text and tests that don't etc.).

[Simon Fraser (smfr)]

r37433 = 8c2bac03b93d3aa1c8b2667ebc9ce1c20dcb3d04 (trunk)
	M	WebKitTools/DumpRenderTree/cg/PixelDumpSupportCG.cpp
	M	WebKitTools/DumpRenderTree/win/DumpRenderTree.cpp
	M	WebKitTools/DumpRenderTree/mac/DumpRenderTree.mm
	M	WebKitTools/ChangeLog
	M	WebKitTools/Scripts/run-webkit-tests