Bug 21323 - run-webkit-tests with --pixel and --reset hangs
Summary: run-webkit-tests with --pixel and --reset hangs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-02 17:18 PDT by Simon Fraser (smfr)
Modified: 2008-10-03 17:17 PDT (History)
0 users

See Also:

Attachments
Patch, changelog (1.69 KB, patch)
2008-10-02 17:20 PDT, Simon Fraser (smfr) 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2008-10-02 17:18:11 PDT 
The tests hang if called with both --pixel and --reset. The problem is that DRT and the script disagree on when the PNG dump is going to happen, so the scripts ends up treating a PNG dump as if it were text output.

This regressed in bug 21124.
Comment 1 Simon Fraser (smfr) 2008-10-02 17:20:38 PDT 
Created attachment 24038 [details]
Patch, changelog
Comment 2 Darin Adler 2008-10-03 17:12:31 PDT 
Comment on attachment 24038 [details]
Patch, changelog

r=me
Comment 3 Simon Fraser (smfr) 2008-10-03 17:17:10 PDT 
	M	WebKitTools/ChangeLog
	M	WebKitTools/Scripts/run-webkit-tests
r37269 = f415948b7306d75e3ffe5fcaaa0a86f040eef251 (trunk)