Bug 214622 - Fix validation of deleted WebGL objects
Summary: Fix validation of deleted WebGL objects
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Darpinian
Keywords: InRadar
Depends on:
Blocks: 126404 126940
  Show dependency treegraph
Reported: 2020-07-21 17:08 PDT by James Darpinian
Modified: 2020-07-22 11:26 PDT (History)
10 users (show)

See Also:

Patch (19.17 KB, patch)
2020-07-21 17:10 PDT, James Darpinian
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Darpinian 2020-07-21 17:08:58 PDT
Fix validation of deleted WebGL objects
Comment 1 James Darpinian 2020-07-21 17:10:53 PDT
Created attachment 404882 [details]
Comment 2 James Darpinian 2020-07-21 17:12:28 PDT
I discovered this while looking at conformance tests for query objects (bug 126940).
Comment 3 Kenneth Russell 2020-07-21 17:23:21 PDT
Comment on attachment 404882 [details]

Looks good to me. Good catch.

Do you think we should bring over two additional concepts from Chromium's WebGL implementation?

- WebGLObject::MarkedForDeletion
- WebGLRenderingContextBase::ValidateNullableWebGLObject


Maybe not in this patch, but in a follow-on one?
Comment 4 James Darpinian 2020-07-21 17:29:26 PDT
Yes, I think there's more work to be done here.
Comment 5 Kenneth Russell 2020-07-21 17:40:43 PDT
Thanks, sounds good. This individual patch LGTM - let's file follow-on bugs.
Comment 6 EWS 2020-07-22 11:25:48 PDT
Committed r264713: <https://trac.webkit.org/changeset/264713>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404882 [details].
Comment 7 Radar WebKit Bug Importer 2020-07-22 11:26:23 PDT