Bug 214535 - JSC build scripts should be quiet by default
Summary: JSC build scripts should be quiet by default
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-19 07:27 PDT by Michael Catanzaro
Modified: 2020-07-20 13:20 PDT (History)
8 users (show)

See Also:

Attachments
Patch (2.66 KB, patch)
2020-07-19 07:31 PDT, Michael Catanzaro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2020-07-19 07:27:10 PDT 
Some of our build scripts have started printing "Nothing changed" on successful operation. For example:

[354/2150] Generating ../../DerivedSources/JavaScriptCore/LLIntDesiredOffsets.h
OffsetExtractor: Nothing changed.
[481/2150] Generating ../../DerivedSources/JavaScriptCore/LLIntAssembly.h
Offlineasm: Nothing changed.

The build logs are nicer if, between 'cmake' and 'cmake install', we only print stuff when there is an actual problem that needs to be investigated. We achieved this long ago (bug #152382) and only a couple changes are needed to get there again.
Comment 1 Michael Catanzaro 2020-07-19 07:31:58 PDT 
Created attachment 404669 [details]
Patch
Comment 2 EWS 2020-07-20 13:19:31 PDT 
Committed r264616: <https://trac.webkit.org/changeset/264616>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404669 [details].
Comment 3 Radar WebKit Bug Importer 2020-07-20 13:20:14 PDT 
<rdar://problem/65844029>