Bug 152382 – JSC generator scripts shouldn't have verbose output

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Csaba Osztrogonác]

Almost all commands of build-webkit don't have any output. These scripts 
are quite stable, I don't think if it is useful to have verbose outputs.

output of build-jsc now: (EFL with ninja)
------------------------------------------
various configure options

[ snip ]

-- Configuring done
-- Generating done
-- Build files have been written to: /home/ossy/WebKit/WebKitBuild/Release
[108/915] Generating ../../DerivedSources/JavaScriptCore/Bytecodes.h, ../../DerivedSources/JavaScriptCore/InitBytecodes.asm
Generating /home/ossy/WebKit/WebKitBuild/Release/DerivedSources/JavaScriptCore/Bytecodes.h and /home/ossy/WebKit/WebKitBuild/Release/DerivedSources/JavaScriptCore/InitBytecodes.asm from /home/ossy/WebKit/Source/JavaScriptCore/bytecode/BytecodeList.json

[109/915] Generating ../../DerivedSources/JavaScriptCore/LLIntDesiredOffsets.h
offlineasm: Parsing /home/ossy/WebKit/Source/JavaScriptCore/llint/LowLevelInterpreter.asm and creating offset extractor /home/ossy/WebKit/WebKitBuild/Release/DerivedSources/JavaScriptCore/LLIntDesiredOffsets.h.
offlineasm: Including file /home/ossy/WebKit/WebKitBuild/Release/DerivedSources/JavaScriptCore//InitBytecodes.asm
offlineasm: Including file /home/ossy/WebKit/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm
offlineasm: Including file /home/ossy/WebKit/Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm
offlineasm: offset extractor /home/ossy/WebKit/WebKitBuild/Release/DerivedSources/JavaScriptCore/LLIntDesiredOffsets.h successfully generated.
[152/915] Generating ../../DerivedSources/JavaScriptCore/AirOpcode.h, ../../DerivedSources/JavaScriptCore/AirOpcodeGenerated.h
Generating code for /home/ossy/WebKit/Source/JavaScriptCore/b3/air/AirOpcode.opcodes.
[152/915] Generating ../../DerivedSources/JavaScriptCore/LLIntAssembly.h
offlineasm: Parsing /home/ossy/WebKit/Source/JavaScriptCore/llint/LowLevelInterpreter.asm and /home/ossy/WebKit/WebKitBuild/Release/bin/LLIntOffsetsExtractor and creating assembly file /home/ossy/WebKit/WebKitBuild/Release/DerivedSources/JavaScriptCore/LLIntAssembly.h.
offlineasm: Including file /home/ossy/WebKit/WebKitBuild/Release/DerivedSources/JavaScriptCore//InitBytecodes.asm
offlineasm: Including file /home/ossy/WebKit/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm
offlineasm: Including file /home/ossy/WebKit/Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm
offlineasm: Assembly file /home/ossy/WebKit/WebKitBuild/Release/DerivedSources/JavaScriptCore/LLIntAssembly.h successfully generated.
[915/915] Linking CXX executable bin/jsc

====================================================================
 JavaScriptCore is now built (03m:14s). 
====================================================================


output after the proposed fix:
-------------------------------
...

-- Configuring done
-- Generating done
-- Build files have been written to: /home/ossy/WebKit/WebKitBuild/Release
[915/915] Linking CXX executable bin/jsc

====================================================================
 JavaScriptCore is now built (03m:07s). 
====================================================================

[Csaba Osztrogonác]

Created attachment 267551 [details]
Patch

[Michael Catanzaro]

Comment on attachment 267551 [details]
Patch

Excellent! I agree, to make our build shine, these should not print anything, at least not by default.

[WebKit Commit Bot]

Comment on attachment 267551 [details]
Patch

Clearing flags on attachment: 267551

Committed r194531: <http://trac.webkit.org/changeset/194531>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.