Let's try to fix this python warning that occurs when running webkit-patch: $ webkit-patch upload /home/mcatanzaro/Projects/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/pep8.py:110: FutureWarning: Possible nested set at position 1 EXTRANEOUS_WHITESPACE_REGEX = re.compile(r'[[({] | []}),;:]') Since we don't control the code, we should update to a newer version of pep8. It has been renamed to pycodestyle. I've tested this patch with python3. I think it should work with python2. Let's see if EWS likes it.
BTW, maybe I'm doing something wrong, but this style checker seems unable to find obvious style errors in our python code even without any of my changes....
Created attachment 404664 [details] Patch
Seems that works. Attaching an alternate patch to see if we can get away with removing pep8 and using pycodestyle also for python2.
Created attachment 404665 [details] Patch
*** Bug 209017 has been marked as a duplicate of this bug. ***
(In reply to Michael Catanzaro from comment #1) > BTW, maybe I'm doing something wrong, but this style checker seems unable to > find obvious style errors in our python code even without any of my > changes.... Apparently I was looking for style rules that we suppress. It actually still works fine if I violate the right rules: $ check-webkit-style ERROR: Source/WebKit/Scripts/generate-message-receiver.py:41: missing whitespace around operator [pep8/E225] [5] ERROR: Source/WebKit/Scripts/generate-message-receiver.py:42: missing whitespace around operator [pep8/E225] [5] ERROR: Source/WebKit/Scripts/generate-message-receiver.py:45: missing whitespace after ',' [pep8/E231] [5] Total errors found: 3 in 3 files Seems good.
Committed r264579: <https://trac.webkit.org/changeset/264579> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404665 [details].
<rdar://problem/65793948>
Reopening to attach new patch.
Created attachment 405204 [details] Patch for landing
(In reply to Jonathan Bedard from comment #10) > Created attachment 405204 [details] > Patch for landing Pep8 was removed from the auto importer, we should remove it from the test as well.
Committed r264872: <https://trac.webkit.org/changeset/264872> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405204 [details].
Comment on attachment 405204 [details] Patch for landing Good catch!