Bug 209017 - pep8.py:110: FutureWarning: Possible nested set at position 1
Summary: pep8.py:110: FutureWarning: Possible nested set at position 1
Status: RESOLVED DUPLICATE of bug 214531
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-03-12 13:48 PDT by Michael Catanzaro
Modified: 2020-07-19 06:54 PDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2020-03-12 13:48:55 PDT
This warning occurs when running webkit-patch with python 3.7.6:

$ webkit-patch upload --request-commit
/home/mcatanzaro/Projects/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/pep8.py:110: FutureWarning: Possible nested set at position 1
  EXTRANEOUS_WHITESPACE_REGEX = re.compile(r'[[({] | []}),;:]')

I think we need to update our autoinstalled modules to replace pep8 with its replacement, pycodestyle.
Comment 1 Michael Catanzaro 2020-03-12 13:54:59 PDT
Hm, sometimes I also see:

/home/mcatanzaro/Projects/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py:3599: FutureWarning: Possible nested set at position 101
  check_identifier_name_in_declaration(filename, line_number, line, file_state, error)
/home/mcatanzaro/Projects/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py:3599: FutureWarning: Possible nested set at position 73
  check_identifier_name_in_declaration(filename, line_number, line, file_state, error)

These are in our own code, though.
Comment 2 Jonathan Bedard 2020-03-13 07:37:16 PDT
(In reply to Michael Catanzaro from comment #0)
> This warning occurs when running webkit-patch with python 3.7.6:
> 
> $ webkit-patch upload --request-commit
> /home/mcatanzaro/Projects/WebKit/Tools/Scripts/webkitpy/thirdparty/
> autoinstalled/pep8.py:110: FutureWarning: Possible nested set at position 1
>   EXTRANEOUS_WHITESPACE_REGEX = re.compile(r'[[({] | []}),;:]')
> 
> I think we need to update our autoinstalled modules to replace pep8 with its
> replacement, pycodestyle.

Does pycodestyle work with Python 2.7?

Our automation is still primarily Python 2.7. Although all scripts should be Python 3 compliant now, we still aren't running things that way in most places.

I think our oldest supported OS is now Mojave, so we probably aren't far from a post-Python 2 world in WebKit, but I haven't had any conversations about that it the last few weeks.
Comment 3 Michael Catanzaro 2020-07-19 06:54:43 PDT
(In reply to Jonathan Bedard from comment #2)
> Does pycodestyle work with Python 2.7?

Apparently so.

*** This bug has been marked as a duplicate of bug 214531 ***