Bug 214530 - cpp_generator.py:134: SyntaxWarning: "is" with a literal. Did you mean "=="?
Summary: cpp_generator.py:134: SyntaxWarning: "is" with a literal. Did you mean "=="?
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
Keywords: InRadar
Depends on:
Reported: 2020-07-19 05:05 PDT by Michael Catanzaro
Modified: 2020-07-19 07:00 PDT (History)
12 users (show)

See Also:

Patch (1.68 KB, patch)
2020-07-19 05:05 PDT, Michael Catanzaro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2020-07-19 05:05:10 PDT
Follow-up to bug #213971, we have one more syntax warning in cpp_generator.py

[663/5091] Generating ../../DerivedSources/JavaScriptCore...s/JavaScriptCore/inspector/InspectorBackendCommands.js.in
/home/mcatanzaro/Projects/WebKit/Source/JavaScriptCore/inspector/scripts/codegen/cpp_generator.py:134: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if isinstance(_type, ObjectType) or _type.qualified_name() is 'object':
Comment 1 Michael Catanzaro 2020-07-19 05:05:59 PDT
Created attachment 404663 [details]
Comment 2 EWS Watchlist 2020-07-19 05:06:40 PDT
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Comment 3 EWS 2020-07-19 06:59:41 PDT
Committed r264576: <https://trac.webkit.org/changeset/264576>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404663 [details].
Comment 4 Radar WebKit Bug Importer 2020-07-19 07:00:17 PDT