Bug 213971 - Web Inspector: Fix python3 build warnings
Summary: Web Inspector: Fix python3 build warnings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-05 05:27 PDT by Philippe Normand
Modified: 2020-07-05 07:24 PDT (History)
12 users (show)

See Also:

Attachments
Patch (13.74 KB, patch)
2020-07-05 06:27 PDT, Philippe Normand 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2020-07-05 05:27:00 PDT 
I get a bunch of those:

Source/JavaScriptCore/inspector/scripts/codegen/cpp_generator.py:70: SyntaxWarning: "is" with a literal. Did you mean "=="?
  elif _type.raw_name() is 'number':
Comment 1 Philippe Normand 2020-07-05 06:27:15 PDT 
Created attachment 403556 [details]
Patch
Comment 2 EWS Watchlist 2020-07-05 06:28:05 PDT 
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Comment 3 EWS 2020-07-05 07:23:07 PDT 
Committed r263951: <https://trac.webkit.org/changeset/263951>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403556 [details].
Comment 4 Radar WebKit Bug Importer 2020-07-05 07:24:15 PDT 
<rdar://problem/65107011>