Bug 214344 – [GTK4] Enable API tests

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Carlos Garcia Campos]

.

[Carlos Garcia Campos]

Created attachment 404327 [details]
Patch

[Adrian Perez]

Comment on attachment 404327 [details]
Patch

Looks fine, I have written a few comments below which you may want to
check before landing :)


View in context: https://bugs.webkit.org/attachment.cgi?id=404327&action=review

> Tools/TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:97
> +    GMainLoop* loop = g_main_loop_new(nullptr, TRUE);

This never gets freed, I would use “GRefPtr<GMainLoop>” here here to avoid a
false positive when using Valgrind (or any other tools) to find leaks. Or use
“g_autoptr(GMainLoop)”, or a plain “g_clear_pointer(&loop, g_main_loop_unref)”.

> Tools/TestWebKitAPI/Tests/WebKitGtk/InspectorTestServer.cpp:48
> +    GMainLoop *loop = g_main_loop_new(nullptr, TRUE);

Same here.

> Tools/TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:667
>  #if USE(GTK4)

Why not remove the “#if” block completely? If the idea is to keep the comment
below for when the tests disabled for GTK4 are brought back then I think it is
okay to leave it around.

> Tools/TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp:278
> +            m_inspectorWindow = nullptr;

Probably I would move the “m_inspectorWindow = nullptr;” line out of the
#if-#endif block, because it's repeated in both cases; but I do not have
a strong opinion on this—feel free to leave it as-is if you think it's more
legible.

[Carlos Garcia Campos]

Created attachment 405556 [details]
Patch for landing

[EWS Watchlist]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Carlos Garcia Campos]

Created attachment 405557 [details]
Patch for landing

[Carlos Garcia Campos]

Committed r265080: <https://trac.webkit.org/changeset/265080>

[Radar WebKit Bug Importer]

<rdar://problem/66317614>