Bug 214251 - [GTK] Prepare unit tests for GTK4
Summary: [GTK] Prepare unit tests for GTK4
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, InRadar
Depends on:
Blocks: GTK4 214344
  Show dependency tree / graph
 
Reported: 2020-07-13 02:49 PDT by Carlos Garcia Campos
Modified: 2020-07-21 01:09 PDT (History)
6 users (show)

See Also:

Attachments
Patch (54.74 KB, patch)
2020-07-13 03:24 PDT, Carlos Garcia Campos 		aperez: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2020-07-13 02:49:27 PDT 
In GTK there isn't GTK_WINDOW_POPUP and we can't create GdkEvents, so we need to use toplevel windows everywhere and use the new internal api to synthesize events.
Comment 1 Carlos Garcia Campos 2020-07-13 03:24:20 PDT 
Created attachment 404140 [details]
Patch
Comment 2 EWS Watchlist 2020-07-13 03:25:08 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Adrian Perez 2020-07-20 09:06:53 PDT 
Comment on attachment 404140 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404140&action=review

> Tools/TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp:45
> +        g_main_context_iteration(nullptr, TRUE);

Wow, it's amazing that it's 2020 and we were still using
the gtk_* main loop functions 😅️
Comment 4 Carlos Garcia Campos 2020-07-21 01:08:27 PDT 
Committed r264647: <https://trac.webkit.org/changeset/264647>
Comment 5 Radar WebKit Bug Importer 2020-07-21 01:09:13 PDT 
<rdar://problem/65871310>