RESOLVED FIXED 213739
[css-flexbox] Don't include scrollbar extents when computing sizes for percentage resolution
https://bugs.webkit.org/show_bug.cgi?id=213739
Summary [css-flexbox] Don't include scrollbar extents when computing sizes for percen...
Sergio Villar Senin
Reported 2020-06-29 09:44:25 PDT
[css-flexbox] Don't include scrollbar extents when computing sizes for percentage resolution
Attachments
Patch (4.81 KB, patch)
2020-06-29 09:47 PDT, Sergio Villar Senin
jfernandez: review+
Sergio Villar Senin
Comment 1 2020-06-29 09:47:27 PDT
Javier Fernandez
Comment 2 2020-06-29 14:33:43 PDT
Please, make sure the patch is not the cause of some of the flakiness detected by the mac2 bots: fast/scrolling/mac/scroll-snapping-in-progress.html
Manuel Rego Casasnovas
Comment 3 2020-06-30 01:05:02 PDT
Comment on attachment 403075 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403075&action=review BTW, about the confusion regarding storing something different than what its name says, in Chromium the solution for that was https://chromium-review.googlesource.com/c/chromium/src/+/1024171/, maybe we should try to port that or something similar into WebKit. > LayoutTests/ChangeLog:8 > + * TestExpectations: Unskipped percentage-heights-004.html. The test is only for heights, wouldn't we need a test for widths too? You're changing both things in the code in I'm not getting it wrong.
Sergio Villar Senin
Comment 4 2020-06-30 01:22:26 PDT
(In reply to Javier Fernandez from comment #2) > Please, make sure the patch is not the cause of some of the flakiness > detected by the mac2 bots: > > fast/scrolling/mac/scroll-snapping-in-progress.html That's failing without the patch as well.
Sergio Villar Senin
Comment 5 2020-06-30 10:23:05 PDT
(In reply to Manuel Rego Casasnovas from comment #3) > Comment on attachment 403075 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=403075&action=review > > BTW, about the confusion regarding storing something different than what its > name says, in Chromium the solution for that was > https://chromium-review.googlesource.com/c/chromium/src/+/1024171/, maybe we > should try to port that or something similar into WebKit. > > > LayoutTests/ChangeLog:8 > > + * TestExpectations: Unskipped percentage-heights-004.html. > > The test is only for heights, wouldn't we need a test for widths too? You're > changing both things in the code in I'm not getting it wrong. Now that you mention it, the width paths are not reachable. I'll post a prequel patch to remove them.
Sergio Villar Senin
Comment 6 2020-07-01 03:41:11 PDT
Radar WebKit Bug Importer
Comment 7 2020-07-01 03:42:14 PDT
Sergio Villar Senin
Comment 8 2020-07-01 03:45:02 PDT
(In reply to Manuel Rego Casasnovas from comment #3) > Comment on attachment 403075 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=403075&action=review > > BTW, about the confusion regarding storing something different than what its > name says, in Chromium the solution for that was > https://chromium-review.googlesource.com/c/chromium/src/+/1024171/, maybe we > should try to port that or something similar into WebKit. > > > LayoutTests/ChangeLog:8 > > + * TestExpectations: Unskipped percentage-heights-004.html. > > The test is only for heights, wouldn't we need a test for widths too? You're > changing both things in the code in I'm not getting it wrong. After landing bug 213809 there is no need to test widths as those code paths were not reachable and thus they're removed.
Note You need to log in before you can comment on or make changes to this bug.