Bug 213809 - [css-flex] Remove dead code paths when evaluating percentage resolution
Summary: [css-flex] Remove dead code paths when evaluating percentage resolution
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sergio Villar Senin
URL:
Keywords: InRadar
Depends on:
Blocks: 213739
  Show dependency treegraph
 
Reported: 2020-06-30 12:29 PDT by Sergio Villar Senin
Modified: 2020-07-01 11:08 PDT (History)
12 users (show)

See Also:


Attachments
Patch (5.07 KB, patch)
2020-06-30 12:35 PDT, Sergio Villar Senin
no flags Details | Formatted Diff | Diff
Patch (5.09 KB, patch)
2020-07-01 03:27 PDT, Sergio Villar Senin
rego: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Villar Senin 2020-06-30 12:29:28 PDT
[css-flex] Remove death paths when evaluating percentage resolution
Comment 1 Sergio Villar Senin 2020-06-30 12:35:26 PDT
Created attachment 403225 [details]
Patch
Comment 2 Simon Fraser (smfr) 2020-06-30 13:49:38 PDT
Can you use a less dramatic name than "death paths"? Do you mean "dead code" paths?
Comment 3 Sergio Villar Senin 2020-07-01 03:25:06 PDT
(In reply to Simon Fraser (smfr) from comment #2)
> Can you use a less dramatic name than "death paths"? Do you mean "dead code"
> paths?

Yeah :), that's what I meant after all.
Comment 4 Sergio Villar Senin 2020-07-01 03:27:31 PDT
Created attachment 403281 [details]
Patch
Comment 5 Manuel Rego Casasnovas 2020-07-01 03:30:45 PDT
Comment on attachment 403281 [details]
Patch

r=me, nice catch!
Comment 6 Sergio Villar Senin 2020-07-01 03:36:52 PDT
Committed r263792: <https://trac.webkit.org/changeset/263792>
Comment 7 Radar WebKit Bug Importer 2020-07-01 03:37:14 PDT
<rdar://problem/64980540>