see https://lists.webkit.org/pipermail/webkit-dev/2020-June/031244.html
Created attachment 403056 [details] Patch
Comment on attachment 403056 [details] Patch r=me once bots are happy. Please revert/update some of the changes made to the generator tests. View in context: https://bugs.webkit.org/attachment.cgi?id=403056&action=review > Source/JavaScriptCore/ChangeLog:8 > + I regeneted expectations by Tools/Scripts/run-builtins-generator-tests regenerated > Source/JavaScriptCore/Scripts/tests/builtins/WebCore-ArbitraryConditionalGuard-Separate.js:-26 > -// @conditional=ENABLE(STREAMS_API) || USE(CF) I do not think we want to remove those since they are checking that the generator works fine. You might want to change the name maybe to make it clear. > Source/JavaScriptCore/Scripts/tests/builtins/expected/WebCore-DuplicateKeyValueAnnotation-Separate.js-result:1 > +### Begin File: DuplicateKeyValueAnnotationBuiltins.h I guess this new file has nothing to do with streams API but we somehow forgot to regenerate expectations. It seems our bots should have caught this missing file.
I seem these flags in generator tests are originated by https://bugs.webkit.org/show_bug.cgi?id=150536
(In reply to youenn fablet from comment #2) > Comment on attachment 403056 [details] > Patch > > r=me once bots are happy. > Please revert/update some of the changes made to the generator tests. Tools/Scripts/run-builtins-generator-tests pass the tests if we revert all changes for Source/JavaScriptCore/Scripts/tests/builtins/. I'll revert them once and plan to fix in another bug.
(In reply to Tetsuharu Ohzeki from comment #4) > (In reply to youenn fablet from comment #2) > > Comment on attachment 403056 [details] > > Patch > > > > r=me once bots are happy. > > Please revert/update some of the changes made to the generator tests. > > Tools/Scripts/run-builtins-generator-tests pass the tests if we revert all > changes for Source/JavaScriptCore/Scripts/tests/builtins/. > > I'll revert them once and plan to fix in another bug. filed bug 213733
Created attachment 403068 [details] Patch
Committed r263700: <https://trac.webkit.org/changeset/263700> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403068 [details].
<rdar://problem/64911262>