Bug 213728 - Remove ENABLE_STREAMS_API compile flag
Summary: Remove ENABLE_STREAMS_API compile flag
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on: 213792
Blocks:
  Show dependency treegraph
 
Reported: 2020-06-29 07:28 PDT by Tetsuharu Ohzeki
Modified: 2020-06-30 06:43 PDT (History)
21 users (show)

See Also:


Attachments
Patch (124.94 KB, patch)
2020-06-29 07:39 PDT, Tetsuharu Ohzeki
no flags Details | Formatted Diff | Diff
Patch (97.23 KB, patch)
2020-06-29 09:08 PDT, Tetsuharu Ohzeki
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Tetsuharu Ohzeki 2020-06-29 07:39:19 PDT
Created attachment 403056 [details]
Patch
Comment 2 youenn fablet 2020-06-29 08:10:39 PDT
Comment on attachment 403056 [details]
Patch

r=me once bots are happy.
Please revert/update some of the changes made to the generator tests.

View in context: https://bugs.webkit.org/attachment.cgi?id=403056&action=review

> Source/JavaScriptCore/ChangeLog:8
> +        I regeneted expectations by Tools/Scripts/run-builtins-generator-tests

regenerated

> Source/JavaScriptCore/Scripts/tests/builtins/WebCore-ArbitraryConditionalGuard-Separate.js:-26
> -// @conditional=ENABLE(STREAMS_API) || USE(CF)

I do not think we want to remove those since they are checking that the generator works fine.
You might want to change the name maybe to make it clear.

> Source/JavaScriptCore/Scripts/tests/builtins/expected/WebCore-DuplicateKeyValueAnnotation-Separate.js-result:1
> +### Begin File: DuplicateKeyValueAnnotationBuiltins.h

I guess this new file has nothing to do with streams API but we somehow forgot to regenerate expectations.
It seems our bots should have caught this missing file.
Comment 3 Tetsuharu Ohzeki 2020-06-29 08:33:03 PDT
I seem these flags in generator tests are originated by https://bugs.webkit.org/show_bug.cgi?id=150536
Comment 4 Tetsuharu Ohzeki 2020-06-29 08:41:01 PDT
(In reply to youenn fablet from comment #2)
> Comment on attachment 403056 [details]
> Patch
> 
> r=me once bots are happy.
> Please revert/update some of the changes made to the generator tests.

Tools/Scripts/run-builtins-generator-tests pass the tests if we revert all changes for Source/JavaScriptCore/Scripts/tests/builtins/.

I'll revert them once and plan to fix in another bug.
Comment 5 Tetsuharu Ohzeki 2020-06-29 08:43:23 PDT
(In reply to Tetsuharu Ohzeki from comment #4)
> (In reply to youenn fablet from comment #2)
> > Comment on attachment 403056 [details]
> > Patch
> > 
> > r=me once bots are happy.
> > Please revert/update some of the changes made to the generator tests.
> 
> Tools/Scripts/run-builtins-generator-tests pass the tests if we revert all
> changes for Source/JavaScriptCore/Scripts/tests/builtins/.
> 
> I'll revert them once and plan to fix in another bug.

filed bug 213733
Comment 6 Tetsuharu Ohzeki 2020-06-29 09:08:40 PDT
Created attachment 403068 [details]
Patch
Comment 7 EWS 2020-06-29 15:40:30 PDT
Committed r263700: <https://trac.webkit.org/changeset/263700>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403068 [details].
Comment 8 Radar WebKit Bug Importer 2020-06-29 15:41:49 PDT
<rdar://problem/64911262>