Bug 213733 - Use properly flag name for testcases of Tools/Scripts/run-builtins-generator-tests
Summary: Use properly flag name for testcases of Tools/Scripts/run-builtins-generator-...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-29 08:43 PDT by Tetsuharu Ohzeki [UTC+9]
Modified: 2020-07-01 00:10 PDT (History)
8 users (show)

See Also:


Attachments
Patch (24.20 KB, patch)
2020-06-30 05:26 PDT, Tetsuharu Ohzeki [UTC+9]
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tetsuharu Ohzeki [UTC+9] 2020-06-29 08:43:07 PDT
Test cases under Source/JavaScriptCore/Scripts/tests/builtins/ uses exist compilation flags.
They are confusable if we remove a compilation flag and I think it's better to rename to more proper ones.


See also bug 213728
Comment 1 Tetsuharu Ohzeki [UTC+9] 2020-06-30 05:26:29 PDT
Created attachment 403190 [details]
Patch
Comment 2 EWS 2020-07-01 00:09:50 PDT
Committed r263790: <https://trac.webkit.org/changeset/263790>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403190 [details].
Comment 3 Radar WebKit Bug Importer 2020-07-01 00:10:16 PDT
<rdar://problem/64974907>