Bug 213452 - [Win] fast/dom/Window/alert-with-unmatched-utf16-surrogate-should-not-crash.html is failing
Summary: [Win] fast/dom/Window/alert-with-unmatched-utf16-surrogate-should-not-crash.h...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-21 21:29 PDT by Fujii Hironori
Modified: 2020-06-22 18:24 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.90 KB, patch)
2020-06-21 21:39 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Patch (3.86 KB, patch)
2020-06-21 21:40 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Patch (5.82 KB, patch)
2020-06-21 22:04 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Patch (5.89 KB, patch)
2020-06-22 12:40 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2020-06-21 21:29:58 PDT 
[Win][WTR] fast/dom/Window/alert-with-unmatched-utf16-surrogate-should-not-crash.html is failing

Since it was added in Bug 213269.
Comment 1 Fujii Hironori 2020-06-21 21:39:13 PDT 
Created attachment 402443 [details]
Patch
Comment 2 Fujii Hironori 2020-06-21 21:40:13 PDT 
Created attachment 402444 [details]
Patch
Comment 3 Fujii Hironori 2020-06-21 22:04:02 PDT 
Created attachment 402445 [details]
Patch
Comment 4 Darin Adler 2020-06-22 08:07:37 PDT 
Comment on attachment 402445 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402445&action=review

> Tools/DumpRenderTree/win/UIDelegate.cpp:458
> +    // Return "(null)" for an invalid UTF-16 sequence

Why not “invalid”? Not sure why we call an invalid sequence null.
Comment 5 Fujii Hironori 2020-06-22 12:27:48 PDT 
Comment on attachment 402445 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402445&action=review

>> Tools/DumpRenderTree/win/UIDelegate.cpp:458
>> +    // Return "(null)" for an invalid UTF-16 sequence
> 
> Why not “invalid”? Not sure why we call an invalid sequence null.

WinCairo is supporting both WK1 and WK2. DRT should behave same with WTR. See Bug 213269 for WTR.
Comment 6 Darin Adler 2020-06-22 12:35:49 PDT 
Then the comment should say why. Generally speaking, comments purpose is to answer the question "why". The code itself answers the question "what".
Comment 7 Fujii Hironori 2020-06-22 12:40:22 PDT 
Created attachment 402495 [details]
Patch
Comment 8 Fujii Hironori 2020-06-22 12:43:09 PDT 
(In reply to Darin Adler from comment #6)
> Then the comment should say why. Generally speaking, comments purpose is to
> answer the question "why". The code itself answers the question "what".

Agreed. Fixed. Thank you.
Comment 9 Yusuke Suzuki 2020-06-22 17:36:13 PDT 
Comment on attachment 402495 [details]
Patch

Nice!
Comment 10 Fujii Hironori 2020-06-22 18:23:39 PDT 
Comment on attachment 402495 [details]
Patch

Clearing flags on attachment: 402495

Committed r263379: <https://trac.webkit.org/changeset/263379>
Comment 11 Fujii Hironori 2020-06-22 18:23:43 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 12 Radar WebKit Bug Importer 2020-06-22 18:24:21 PDT 
<rdar://problem/64618144>