Bug 213269 - WebKitTestRunner should not crash on alert with invalid utf16 strings
Summary: WebKitTestRunner should not crash on alert with invalid utf16 strings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-16 16:24 PDT by Keith Miller
Modified: 2020-06-21 21:44 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.24 KB, patch)
2020-06-16 16:25 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch for landing (3.23 KB, patch)
2020-06-17 09:52 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2020-06-16 16:24:47 PDT 
WebKitTestRunner should not crash on alert with invalid utf16 strings
Comment 1 Keith Miller 2020-06-16 16:25:08 PDT 
Created attachment 402054 [details]
Patch
Comment 2 Yusuke Suzuki 2020-06-16 17:54:09 PDT 
Comment on attachment 402054 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402054&action=review

> LayoutTests/fast/dom/Window/alert-with-unmatched-utf16-surrogate-should-not-crash.html:2
> +  alert(String.fromCharCode(0xd800));

I recommend putting js-test-pre and js-test-post to avoid using rendering test like the above -expected.txt.
Comment 3 Keith Miller 2020-06-17 09:52:42 PDT 
Created attachment 402120 [details]
Patch for landing
Comment 4 EWS 2020-06-17 10:28:20 PDT 
Committed r263164: <https://trac.webkit.org/changeset/263164>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402120 [details].
Comment 5 Radar WebKit Bug Importer 2020-06-17 10:29:18 PDT 
<rdar://problem/64453630>
Comment 6 Radar WebKit Bug Importer 2020-06-17 10:29:19 PDT 
<rdar://problem/64453632>
Comment 7 Yusuke Suzuki 2020-06-18 16:34:54 PDT 
Committed r263245: <https://trac.webkit.org/changeset/263245>
Comment 8 Yusuke Suzuki 2020-06-18 18:04:30 PDT 
Committed r263249: <https://trac.webkit.org/changeset/263249>
Comment 9 Fujii Hironori 2020-06-21 21:44:36 PDT 
(In reply to Yusuke Suzuki from comment #8)
> Committed r263249: <https://trac.webkit.org/changeset/263249>

Filed : Bug 213452 – [Win][WTR] fast/dom/Window/alert-with-unmatched-utf16-surrogate-should-not-crash.html is failing