Bug 213441 - Keyframe animation doesn't 't show up in the Animations timeline
Summary: Keyframe animation doesn't 't show up in the Animations timeline
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-20 20:15 PDT by Simon Fraser (smfr)
Modified: 2020-06-23 09:13 PDT (History)
17 users (show)

See Also:

Attachments
Testcase (1.64 KB, text/html)
2020-06-20 20:15 PDT, Simon Fraser (smfr) 		no flags Details
Patch (18.25 KB, patch)
2020-06-22 20:05 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (19.08 KB, patch)
2020-06-22 21:14 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2020-06-20 20:15:33 PDT 
Created attachment 402413 [details]
Testcase

With the attached testcase, I don't see a green bar in the "Media and Animations" bar in the timelines tab, even after reload. Webkit r263322 inspected by Safari at r263222.
Comment 1 Simon Fraser (smfr) 2020-06-20 20:22:33 PDT 
Doesn't work with Safari inspecting itself either.
Comment 2 Devin Rousso 2020-06-22 20:05:58 PDT 
Created attachment 402529 [details]
Patch
Comment 3 Devin Rousso 2020-06-22 21:14:12 PDT 
Created attachment 402532 [details]
Patch
Comment 4 EWS Watchlist 2020-06-22 21:14:48 PDT 
This patch modifies the inspector protocol. Please ensure that any frontend changes appropriately use feature checks for new protocol features.
Comment 5 BJ Burg 2020-06-23 08:51:09 PDT 
Comment on attachment 402532 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402532&action=review

r=me. EWS failure seems unrelated.

> Source/WebInspectorUI/UserInterface/Models/Animation.js:252
> +                // COMPATIBILITY (iOS 14): an iteration count of `Infinity` was not properly handled.

Nice.
Comment 6 EWS 2020-06-23 09:12:41 PDT 
Committed r263400: <https://trac.webkit.org/changeset/263400>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402532 [details].
Comment 7 Radar WebKit Bug Importer 2020-06-23 09:13:15 PDT 
<rdar://problem/64646884>