Bug 213229 - Provide alternatively-named WKBrowsingContextGroup SPI
Summary: Provide alternatively-named WKBrowsingContextGroup SPI
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
Keywords: InRadar
Depends on:
Blocks: 213092
  Show dependency treegraph
Reported: 2020-06-15 21:12 PDT by Alex Christensen
Modified: 2020-06-16 10:58 PDT (History)
4 users (show)

See Also:

Patch (7.28 KB, patch)
2020-06-15 21:14 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (7.38 KB, patch)
2020-06-15 21:15 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2020-06-15 21:12:04 PDT
Provide alternatively-named WKBrowsingContextGroup SPI
Comment 1 Alex Christensen 2020-06-15 21:14:36 PDT
Created attachment 401977 [details]
Comment 2 Alex Christensen 2020-06-15 21:15:02 PDT
Created attachment 401978 [details]
Comment 3 Tim Horton 2020-06-16 10:44:31 PDT
Comment on attachment 401978 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=401978&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKBrowsingContextGroup.h:44
> +- (void)addUserScript:(NSString *)source baseURL:(NSURL *)baseURL includeMatchPatternStrings:(NSArray<NSString *> *)includeMatchPatternStrings excludeMatchPatternStrings:(NSArray<NSString *> *)excludeMatchPatternStrings injectionTime:(_WKUserScriptInjectionTime)injectionTime mainFrameOnly:(BOOL)mainFrameOnly;

Not sure "include match pattern strings" quite reads as a parseable phrase to me.
Comment 4 EWS 2020-06-16 10:57:23 PDT
Committed r263099: <https://trac.webkit.org/changeset/263099>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401978 [details].
Comment 5 Radar WebKit Bug Importer 2020-06-16 10:58:20 PDT