RESOLVED FIXED 213229
Provide alternatively-named WKBrowsingContextGroup SPI 
https://bugs.webkit.org/show_bug.cgi?id=213229
Summary Provide alternatively-named WKBrowsingContextGroup SPI
Alex Christensen
Reported 2020-06-15 21:12:04 PDT
Provide alternatively-named WKBrowsingContextGroup SPI
Attachments
Patch (7.28 KB, patch)
2020-06-15 21:14 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (7.38 KB, patch)
2020-06-15 21:15 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2020-06-15 21:14:36 PDT
Created attachment 401977 [details] Patch
Alex Christensen
Comment 2 2020-06-15 21:15:02 PDT
Created attachment 401978 [details] Patch
Tim Horton
Comment 3 2020-06-16 10:44:31 PDT
Comment on attachment 401978 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401978&action=review > Source/WebKit/UIProcess/API/Cocoa/WKBrowsingContextGroup.h:44 > +- (void)addUserScript:(NSString *)source baseURL:(NSURL *)baseURL includeMatchPatternStrings:(NSArray<NSString *> *)includeMatchPatternStrings excludeMatchPatternStrings:(NSArray<NSString *> *)excludeMatchPatternStrings injectionTime:(_WKUserScriptInjectionTime)injectionTime mainFrameOnly:(BOOL)mainFrameOnly; Not sure "include match pattern strings" quite reads as a parseable phrase to me.
EWS
Comment 4 2020-06-16 10:57:23 PDT
Committed r263099: <https://trac.webkit.org/changeset/263099> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401978 [details].
Radar WebKit Bug Importer
Comment 5 2020-06-16 10:58:20 PDT
<rdar://problem/64413468>
Note You need to log in before you can comment on or make changes to this bug.