Bug 213109 – Add SPI to preconnect to a server

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alex Christensen]

Add SPI to preconnect to a server

[Alex Christensen]

Created attachment 401703 [details]
Patch

[Geoffrey Garen]

Comment on attachment 401703 [details]
Patch

r=me

[Alex Christensen]

Comment on attachment 401703 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401703&action=review

> Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:1475
> -    if (!url.isValid() || !url.protocolIsInHTTPFamily() || SecurityOrigin::isLocalHostOrLoopbackIPAddress(url.host()))
> +    if (!url.isValid() || !url.protocolIsInHTTPFamily())

It looks like this change made some tests fail.  The use of isLocalHostOrLoopbackIPAddress was probably covering up some bugs.

[Chris Dumez]

(In reply to Alex Christensen from comment #3)
> Comment on attachment 401703 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=401703&action=review
> 
> > Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:1475
> > -    if (!url.isValid() || !url.protocolIsInHTTPFamily() || SecurityOrigin::isLocalHostOrLoopbackIPAddress(url.host()))
> > +    if (!url.isValid() || !url.protocolIsInHTTPFamily())
> 
> It looks like this change made some tests fail.  The use of
> isLocalHostOrLoopbackIPAddress was probably covering up some bugs.

Yes, we totally added that because the basic HTTPServer in API tests did not like the preconnects.

[Radar WebKit Bug Importer]

<rdar://problem/64302572>

[Maciej Stachowiak]

<rdar://problem/64184412>

[Alex Christensen]

Fixing that separate issue in https://bugs.webkit.org/show_bug.cgi?id=213144

[Alex Christensen]

Created attachment 401805 [details]
Patch

[Maciej Stachowiak]

Preconnect test still seems to be failing with the latest change.

[Alex Christensen]

Created attachment 401925 [details]
Patch

[EWS]

Committed r263057: <https://trac.webkit.org/changeset/263057>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401925 [details].

[Jonathan Bedard]

Reopening to attach new patch.

[Jonathan Bedard]

Created attachment 402244 [details]
Patch for landing

[Jonathan Bedard]

(In reply to Jonathan Bedard from comment #13)
> Created attachment 402244 [details]
> Patch for landing

Build fix for Catalyst.

[EWS]

Committed r263242: <https://trac.webkit.org/changeset/263242>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402244 [details].