Add SPI to preconnect to a server
Created attachment 401703 [details] Patch
Comment on attachment 401703 [details] Patch r=me
Comment on attachment 401703 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401703&action=review > Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:1475 > - if (!url.isValid() || !url.protocolIsInHTTPFamily() || SecurityOrigin::isLocalHostOrLoopbackIPAddress(url.host())) > + if (!url.isValid() || !url.protocolIsInHTTPFamily()) It looks like this change made some tests fail. The use of isLocalHostOrLoopbackIPAddress was probably covering up some bugs.
(In reply to Alex Christensen from comment #3) > Comment on attachment 401703 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=401703&action=review > > > Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:1475 > > - if (!url.isValid() || !url.protocolIsInHTTPFamily() || SecurityOrigin::isLocalHostOrLoopbackIPAddress(url.host())) > > + if (!url.isValid() || !url.protocolIsInHTTPFamily()) > > It looks like this change made some tests fail. The use of > isLocalHostOrLoopbackIPAddress was probably covering up some bugs. Yes, we totally added that because the basic HTTPServer in API tests did not like the preconnects.
<rdar://problem/64302572>
<rdar://problem/64184412>
Fixing that separate issue in https://bugs.webkit.org/show_bug.cgi?id=213144
Created attachment 401805 [details] Patch
Preconnect test still seems to be failing with the latest change.
Created attachment 401925 [details] Patch
Committed r263057: <https://trac.webkit.org/changeset/263057> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401925 [details].
Reopening to attach new patch.
Created attachment 402244 [details] Patch for landing
(In reply to Jonathan Bedard from comment #13) > Created attachment 402244 [details] > Patch for landing Build fix for Catalyst.
Committed r263242: <https://trac.webkit.org/changeset/263242> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402244 [details].