Bug 213144 - Make API tests tolerant of our relatively new use of WebPageProxy::preconnectTo
Summary: Make API tests tolerant of our relatively new use of WebPageProxy::preconnectTo
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-12 13:19 PDT by Alex Christensen
Modified: 2020-06-15 15:35 PDT (History)
4 users (show)

See Also:

Attachments
Patch (13.81 KB, patch)
2020-06-12 13:29 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (18.04 KB, patch)
2020-06-12 14:58 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (1.21 KB, patch)
2020-06-15 15:29 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2020-06-12 13:19:39 PDT 
Make API tests tolerant of our relatively new use of WebPageProxy::preconnectTo
Comment 1 Alex Christensen 2020-06-12 13:29:39 PDT 
Created attachment 401771 [details]
Patch
Comment 2 Geoffrey Garen 2020-06-12 13:53:08 PDT 
Comment on attachment 401771 [details]
Patch

r=me
Comment 3 Alex Christensen 2020-06-12 14:53:13 PDT 
Looks like MultipleClientCertificateConnections tests also need fixing.  That was a real regression that was covered up.
Comment 4 Alex Christensen 2020-06-12 14:58:55 PDT 
Created attachment 401789 [details]
Patch
Comment 5 Geoffrey Garen 2020-06-12 15:14:34 PDT 
Comment on attachment 401789 [details]
Patch

r=me
Comment 6 EWS 2020-06-12 15:58:06 PDT 
Geofferey Garen found in /Volumes/Data/worker/Commit-Queue/build/Tools/ChangeLog does not appear to be a valid reviewer according to contributors.json.
/Volumes/Data/worker/Commit-Queue/build/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Comment 7 Chris Dumez 2020-06-12 16:01:24 PDT 
(In reply to EWS from comment #6)
> Geofferey Garen found in
> /Volumes/Data/worker/Commit-Queue/build/Tools/ChangeLog does not appear to
> be a valid reviewer according to contributors.json.

That's why I go with "Geoff Garen" in ChangeLogs :P
Comment 8 Alex Christensen 2020-06-12 16:32:29 PDT 
http://trac.webkit.org/r262985
Comment 9 Radar WebKit Bug Importer 2020-06-12 16:33:19 PDT 
<rdar://problem/64316743>
Comment 10 Jonathan Bedard 2020-06-15 15:29:24 PDT 
Reopening to attach new patch.
Comment 11 Jonathan Bedard 2020-06-15 15:29:25 PDT 
Created attachment 401950 [details]
Patch
Comment 12 Alex Christensen 2020-06-15 15:35:12 PDT 
https://trac.webkit.org/changeset/263066/webkit