Bug 213088 – Style checker should check for non-inclusive terminology

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Simon Fraser (smfr)]

The style checker should point out uses of non-inclusive terminology in patches, specifically blacklist/whitelist, master/slave.

[Jonathan Bedard]

(In reply to Simon Fraser (smfr) from comment #0)
> The style checker should point out uses of non-inclusive terminology in
> patches, specifically blacklist/whitelist, master/slave.

Removing 'slave' references requires transitioning to buildbot 0.9, if I recall (although Aakash is expert here)

Removing 'master' references is not something I think we can reasonably track in this bug, as newer versions of buildbot still use it to refer to the 'build-master'. Any generalized git tooling will also use 'master' to refer to the default branch since that's what the vast majority of projects use to refer to their primary branch.

[Simon Fraser (smfr)]

Let's start with blacklist/whitelist.

[Aakash Jain]

Created attachment 428859 [details]
Patch

[Aakash Jain]

Style EWS failure in https://ews-build.webkit.org/#/builders/6/builds/47628 is expected (and shows that this code is working).

[Jonathan Bedard]

Comment on attachment 428859 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428859&action=review

> Tools/Scripts/webkitpy/style/checkers/inclusive_language.py:37
> +                                        'Line contains non-inclusive term.')

Can we print the term considered non-inclusive here too?

[Aakash Jain]

Created attachment 428867 [details]
Patch

[Aakash Jain]

(In reply to Jonathan Bedard from comment #5)
> Can we print the term considered non-inclusive here too?
Done in updated patch.

[EWS]

Committed r277612 (237827@main): <https://commits.webkit.org/237827@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428867 [details].

[Radar WebKit Bug Importer]

<rdar://problem/78127249>