Some tests in css/css-color/parsing/system-color-valid.html are failing
Created attachment 400948 [details] Patch
I am not 100% sure about the mappings I picked. Would like feedback on them.
This patch modifies the imported WPT tests. Please ensure that any changes on the tests are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment on attachment 400948 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=400948&action=review > LayoutTests/imported/w3c/web-platform-tests/css/css-color/lab-001.html:9 > + .test {color: lab(46.277% -47.562 48.583)} /* green (sRGB #008000) converted to Lab */ I think you need to update color WPT first (see https://github.com/web-platform-tests/wpt/issues/20993).
Comment on attachment 400948 [details] Patch Everything about this patch seems good to me. But if Simon’s comment means it should not be landed like this, please do respect that rather than landing based on my review. I don’t know what "update color WPT" means.
I didn't either. Simon explained offline that the process is to update the WPT imports as its own commit, rather than doing with another change. I will do that.
(In reply to Sam Weinig from comment #6) > I didn't either. Simon explained offline that the process is to update the > WPT imports as its own commit, rather than doing with another change. I will > do that. Filed 212842 to update the imports first.
Created attachment 401201 [details] Patch
Committed r262658: <https://trac.webkit.org/changeset/262658> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401201 [details].
<rdar://problem/64046692>
*** Bug 203319 has been marked as a duplicate of this bug. ***