Bug 212703 - Some tests in css/css-color/parsing/system-color-valid.html are failing
Summary: Some tests in css/css-color/parsing/system-color-valid.html are failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
: 203319 (view as bug list)
Depends on: 212842
Blocks:
  Show dependency treegraph
 
Reported: 2020-06-03 09:28 PDT by Sam Weinig
Modified: 2022-07-01 13:24 PDT (History)
17 users (show)

See Also:


Attachments
Patch (64.01 KB, patch)
2020-06-03 11:25 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (40.79 KB, patch)
2020-06-05 14:32 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2020-06-03 09:28:46 PDT
Some tests in css/css-color/parsing/system-color-valid.html are failing
Comment 1 Sam Weinig 2020-06-03 11:25:53 PDT
Created attachment 400948 [details]
Patch
Comment 2 Sam Weinig 2020-06-03 11:26:24 PDT
I am not 100% sure about the mappings I picked. Would like feedback on them.
Comment 3 EWS Watchlist 2020-06-03 11:36:08 PDT
This patch modifies the imported WPT tests. Please ensure that any changes on the tests are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 4 Simon Fraser (smfr) 2020-06-04 10:22:59 PDT
Comment on attachment 400948 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400948&action=review

> LayoutTests/imported/w3c/web-platform-tests/css/css-color/lab-001.html:9
> +    .test {color: lab(46.277% -47.562 48.583)} /* green (sRGB #008000) converted to Lab */

I think you need to update color WPT first (see https://github.com/web-platform-tests/wpt/issues/20993).
Comment 5 Darin Adler 2020-06-04 10:49:50 PDT
Comment on attachment 400948 [details]
Patch

Everything about this patch seems good to me. But if Simon’s comment means it should not be landed like this, please do respect that rather than landing based on my review. I don’t know what "update color WPT" means.
Comment 6 Sam Weinig 2020-06-04 13:06:57 PDT
I didn't either. Simon explained offline that the process is to update the WPT imports as its own commit, rather than doing with another change. I will do that.
Comment 7 Sam Weinig 2020-06-05 12:23:44 PDT
(In reply to Sam Weinig from comment #6)
> I didn't either. Simon explained offline that the process is to update the
> WPT imports as its own commit, rather than doing with another change. I will
> do that.

Filed 212842 to update the imports first.
Comment 8 Sam Weinig 2020-06-05 14:32:40 PDT
Created attachment 401201 [details]
Patch
Comment 9 EWS 2020-06-05 15:05:39 PDT
Committed r262658: <https://trac.webkit.org/changeset/262658>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401201 [details].
Comment 10 Radar WebKit Bug Importer 2020-06-05 15:06:20 PDT
<rdar://problem/64046692>
Comment 11 Brent Fulgham 2022-07-01 13:24:38 PDT
*** Bug 203319 has been marked as a duplicate of this bug. ***